From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DCFE3D332F for ; Mon, 4 May 2026 12:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897997; cv=none; b=HkrzpyGc08G56fcT7D4TatB0DJIoGCFTOit7zqLi2ubBCHzd1MBB3SMtoFDo8YJn0DDy+2XKe+Zim32ctZUWBwhM1hA7mgytCx9Q8NXIQAWH2KdM+HQelrz/dUcT2tizgY68wUMvumdHa9QAmeg9jyJJsMHMDiMfzWsSOH9Xkx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777897997; c=relaxed/simple; bh=LA1iLLIBKGSqtuYqkYcNQYTiEQFmcJ4cV7wZm2qC/PU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Zro0ejLyC+46B+s1YZ4Cy91Mzb8WBWTXYzUOeLEgakGwY/1uAcRs2kQ+6LU/prVcMvcplBK83Y3CC7zNh2Jk4p6QbGj2ZftsSXcp2UY+mLd5DqxbJq1xOnFQd40/7iO+76KP6hHxORizlzuzl4QkI9Zhu/KK0C4lFLDT/OCL0c8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CoB4RQQJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CoB4RQQJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE8A0C2BCB8; Mon, 4 May 2026 12:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777897997; bh=LA1iLLIBKGSqtuYqkYcNQYTiEQFmcJ4cV7wZm2qC/PU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=CoB4RQQJaumPYMEwrV4y7Wo+oUqeWjddWOodEV8YfxYmYJUJzbw9Wiu9SjHA5zpEB J7W6a41Zys8k3f++8yirXpAwwCwUrwO58Ae7pKD1jv8LgxP3xNYzGV227bquDARcDQ AjUxxnzkor+xdDaHX5WrW2BXuzYGJvsYQNLDBo1TvK9ID6Eequrxo+FsVRn/10N9m7 MlahN3TmZy82LP+WK3ke3NkO9B+LioA2CaVr3J9A+vDGIC9ZXCZ0UoFFjCeSzypeBU 0kVE5sdbY/OXQ2DHga2a5WbAdaKrUwXvq/C59u4yjN2bVhKuc4spaoL4B+f0zh/i3p z7kO8dJEn3M5w== From: Pratyush Yadav To: Pratyush Yadav Cc: Pasha Tatashin , Mike Rapoport , Michal Clapinski , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock tests: define MIGRATE_CMA In-Reply-To: <2vxz8q9z2w6t.fsf@kernel.org> (Pratyush Yadav's message of "Mon, 04 May 2026 14:31:06 +0200") References: <20260504102742.3833159-1-pratyush@kernel.org> <2vxz8q9z2w6t.fsf@kernel.org> Date: Mon, 04 May 2026 14:33:14 +0200 Message-ID: <2vxz4ikn2w39.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, May 04 2026, Pratyush Yadav wrote: > On Mon, May 04 2026, Pasha Tatashin wrote: > >> On Mon, May 4, 2026 at 6:27=E2=80=AFAM Pratyush Yadav wrote: >>> >>> From: "Pratyush Yadav (Google)" >>> >>> kho_scratch_migratetype(), defined in include/linux/memblock.h uses enum >>> migratetype. This breaks build for memblock tests with: >>> >>> ./linux/memblock.h:634:73: error: parameter 2 (=E2=80=98mt=E2=80=99) ha= s incomplete type >>> 634 | enum mig= ratetype mt) >>> >>> Fix it by defining enum migratetype and MIGRATE_CMA. As is the case with >>> the other headers in tools/testing/memblock, do not bring in the whole >>> thing, only what is needed. >>> >>> Reported-by: Mike Rapoport >>> Closes: https://lore.kernel.org/linux-mm/afcdDm4aAJvNaQqH@kernel.org/ >> >> Link does not open for me. > > Dunno why. Works fine for me... Maybe some temporary issue with lore? Or, look for the thread under "Re: [PATCH v9 0/3] kho: add support for deferred struct page init" in your mailbox. --=20 Regards, Pratyush Yadav