Re: [PATCH] mtd: spi-nor: micron-st: Enable die erase support for MT35XU02GCBA

[Pratyush Yadav <pratyush@kernel.org>]

On Mon, Mar 23 2026, Haoyu Lu wrote:

> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> The MT35XU02GCBA flash device does not support chip erase according
> to its datasheet, but supports die erase. The existing code had a TODO
> comment noting that the SPI_NOR_IO_MODE_EN_VOLATILE flag probably needs
> to be enabled and the driver implementation needs to be converted to
> use die erase.
>
> This patch enables the SPI_NOR_IO_MODE_EN_VOLATILE flag and adds the
> mt35xu01gbba_fixups to the MT35XU02GCBA entry, which includes the
> micron_st_nor_two_die_late_init() function that sets up die erase
> support.
>
> With these changes, the flash device can properly use die erase
> operations instead of chip erase.
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---
>  drivers/mtd/spi-nor/micron-st.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/micron-st.c b/drivers/mtd/spi-nor/micron-st.c
> index 88033384a71e..4e8c6ef14697 100644
> --- a/drivers/mtd/spi-nor/micron-st.c
> +++ b/drivers/mtd/spi-nor/micron-st.c
> @@ -220,7 +220,8 @@ static const struct flash_info micron_nor_parts[] = {
>  		.size = SZ_256M,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_OCTAL_READ,
>  		.mfr_flags = USE_FSR,

Since the TODO comment is now resolved with this patch, please remove
it.

> -		.fixup_flags = SPI_NOR_4B_OPCODES,
> +		.fixup_flags = SPI_NOR_4B_OPCODES | SPI_NOR_IO_MODE_EN_VOLATILE,
> +		.fixups = &mt35xu01gbba_fixups,

Also, rename mt35xu01gbba_fixups to something like "mt35_two_die_fixups"
so the naming isn't confusing.

With that,

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

>  	},
>  };

-- 
Regards,
Pratyush Yadav