From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5292DC332 for ; Tue, 27 Jan 2026 09:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506188; cv=none; b=QNRPthEXpKWjMyGywkgLVKQEKxnQQcYLzas2w3lVpvRX/lFF4SvbJo9uUkL6jPc1oyQ0h1E3yIeS1esddAi8Yaplx2SRAoe2OEfd/Tvk9bKz0K0eflK3K7rsKkEgEjQ9mrFIY5OrsW70/2TNhRmXST/jfCd4DN7mGktUEWBAL0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506188; c=relaxed/simple; bh=KbuD8VI9qE2RW+UjdlUAMiWNgxpjBHRyOL2IKLMpQ/g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UMOWAUPcu3U5XcMS93IMjb3IYwAK9OsSU5+w+wF7gRBuL/buonqeRn49xPaIgFNHDYl63n1nwtGPP57b0y3oM/HV276OvVDQr1l9mP9lsfni/l8nqu69lpgD+cQb29xVe10bihoq1hd+mCMB4TyWQ9UasR9Loy6MvP5SZBAnMbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aqoE/WeG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aqoE/WeG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DD2CC16AAE; Tue, 27 Jan 2026 09:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769506188; bh=KbuD8VI9qE2RW+UjdlUAMiWNgxpjBHRyOL2IKLMpQ/g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=aqoE/WeGYI8SXZM/WQsI0BrG/uffO9ILMR28rlcvE1XrVbNfp6fD2ql4csfZg3mH2 NiCKlSyMu2/lppn+f3Tj0iOQcTx/y9XGKV+AxvSL9tmr4C/LF2CUXDC5yXKdBso7c2 dx5uatyuaYMnzYgvhzkbiSegWlZBpUkygCtt1L3drPX/mUreCsccyWb6HPx4Rt/fXp FcCqvZ2hWNSjZ3S5Fat9r6kLPF9REQG8/Jxa2pcXD1e8MIXyjkXC5gBafDQBTWGKMv Lb9I0baBSkFpSVv9qKYAo5v/RN9pVWgx2zKu5Ngmr/Wg6BW0fGzhYKyhVbHUFI8mN+ LsM4gvb5CV5pA== From: Pratyush Yadav To: Mike Rapoport Cc: Andrew Morton , Alexander Graf , Pasha Tatashin , Pratyush Yadav , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] kho: cleanup error handling in kho_populate() In-Reply-To: <20260122121757.575987-1-rppt@kernel.org> (Mike Rapoport's message of "Thu, 22 Jan 2026 14:17:57 +0200") References: <20260122121757.575987-1-rppt@kernel.org> Date: Tue, 27 Jan 2026 10:29:45 +0100 Message-ID: <2vxz5x8n9zee.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jan 22 2026, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > * use dedicated labels for error handling instead of checking if a pointer > is not null to decide if it should be unmapped > * drop assignment of values to err that are only used to print a numeric > error code, there are pr_warn()s for each failure already so printing a > numeric error code in the next line does not add anything useful > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav