From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 491F9425CEE for ; Mon, 11 May 2026 16:48:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518121; cv=none; b=P5tPBbG49PVCznTKM8R/Mx9Dw16e7vqur8ftvvS+qQi2qGML+OEDFsVf5tASwwqGo77XbwvpBs5M9SuYtq7knK/UsITd4S4S5uUo8RG5am3POiLMB0A48pMl8FeZeGcbbZriKz9yBdPBMsucfLsyPpPnxozArJBan87IqEIUUL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778518121; c=relaxed/simple; bh=QQGKCQXAtFFxjOd54vbilU9n1JNF7kVa2ekxD5peAds=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iMF2HkSduvmtaFe+2hx0G7iKC6cGGchPMNV3pDSfO4sAL0l8HfuMKTCTHvPQTSbl0tF11XyojGbsyjiVBO3E1qfHDlqIHVaA4nxtQjHpKXhTVKECfXj1BZNRrcWIyL6P6bVSqYepMNAphdI7q2iQZt8uRDh45INd9rEnmVDvaWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K5XIpmrI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K5XIpmrI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB6EFC2BCB0; Mon, 11 May 2026 16:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778518120; bh=QQGKCQXAtFFxjOd54vbilU9n1JNF7kVa2ekxD5peAds=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=K5XIpmrIAV/EGwIzcIzruPImlbD5rxQPu7qAr+y4fWfSrVRzeAUiPf0NmgswdXG8q UEhHoDOyTtOUgWhO6lVxIZ7X1xlIp/Fa5itBYE/YcMMWo5DRg5qerGQTFtNGwoADkn xta5TMHWThbryariRnvp3CDvuri4wcDfS/qG+e/mUHrR2qg3ZeagEIhg/hfAeBJUtX n4VxRiB0SufY4hZXWTbw957xB7AWNqygka1jMpQwuT2tF14af+A3M81ANr9x4SYRe2 0XBpI8tLpYzDK6ci9Cp8EobEiY6fpRIN/YXN2BYe5UNdPQEoJhgEU9egOzVtFDTgIT Oh1jbHOfE7Ldg== From: Pratyush Yadav To: Mike Rapoport Cc: Pratyush Yadav , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/12] kho: return virtual address of mem_map In-Reply-To: (Mike Rapoport's message of "Mon, 11 May 2026 15:13:00 +0300") References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-12-pratyush@kernel.org> Date: Mon, 11 May 2026 18:48:37 +0200 Message-ID: <2vxza4u5c2oq.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, May 11 2026, Mike Rapoport wrote: > On Wed, Apr 29, 2026 at 03:39:13PM +0200, Pratyush Yadav wrote: >> From: "Pratyush Yadav (Google)" >> >> There are currently 3 callers of kho_get_mem_map_phys(). Two of them, >> kho_mem_retrieve() and kho_extend_scratch() need the virtual address. >> The third, kho_populate() doesn't care. Make things simpler by >> directly returning the virtual address. Rename kho_get_mem_map_phys() to >> kho_get_mem_map() to accurately reflect what it returns. > > This should be moved earlier, before replacing open-coded get_mem_map() > with a call to kho_get_mem_map_phys(). Do you mean move it before patch 2 "kho: store incoming radix tree in kho_in"? I can do that. I did it this way to show a clear need for this function, but I don't mind doing it as a preparatory step. > >> Signed-off-by: Pratyush Yadav (Google) >> --- >> kernel/liveupdate/kexec_handover.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) -- Regards, Pratyush Yadav