From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47040E56A for ; Sun, 5 Apr 2026 07:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775374511; cv=none; b=rMDaKn+vVT6exTIyz4KWfob7iPfjswCKZHannCn2twfebnMRCYtLPI3u5tjnv/1xOHqz89G87XWCKwjwF2bWIMIAcaouS4lORi/9SelGM4ygmfiKkljITrGylP+qamQRXMSVnC/Us7isETttjaCyGJ2RUZQpNL5epwNNMbO2V2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775374511; c=relaxed/simple; bh=9ecWkdlNPF3P2xs/tOYY5E7/thp4SyQi0bQ5YvQkslo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=tKSgMKZ6qJ4WMWYPrB1mgaNGXXkK1nWpDfErIA+3/cAfCS7PEeOAvRCwQu+AP4v9sBvYCARf2/Ik9nW0Aaxt6RRLpRdWOJ8WrUaUZQBy34ukIeUzAAKwrbl87+UJVbSWNOk91jtah6Y+uGMyQXDnUhS14DU5e88RkEw3dk1IURU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bh/0Jsro; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bh/0Jsro" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9857CC116C6; Sun, 5 Apr 2026 07:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775374511; bh=9ecWkdlNPF3P2xs/tOYY5E7/thp4SyQi0bQ5YvQkslo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Bh/0Jsroy8EtGkUEC+85PBae9D4XOcMz7yTuPbLw0Nb5XxKadkWIvoe9OAcGro9An WCiyB9R/yLusYqSTH571q/MJI+aSC+n4B9CJASldtBTHXpD0blGuEjOz9hCihzJsMV CNCmvfmQs9jwiLTgMQz/Wz8XrjPsQuFKCiBX5wgCeO5g53QpDRbjgIX+nrm3nEEUPw zvVmZAVzFJKmkSBLiLiqArrbYZ1zW2qMawFhOtLIUIZkorPNHNsHJX79Y0/eVXF1UH CCAfm0K3/dqSHHi0+qPK63x0NL/sxHTS0V5QdJgcMaS/DYhQT58lm6PmVeQBUVwXRM pqZCEkbyfWkog== From: Pratyush Yadav To: Leo Timmins Cc: Andrew Morton , Pratyush Yadav , pasha.tatashin@soleen.com, rppt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] liveupdate: initialize incoming FLB state before finish In-Reply-To: (Leo Timmins's message of "Sat, 4 Apr 2026 23:43:44 +0800") References: <20260326042546.8031-1-leotimmins1974@gmail.com> <20260326042546.8031-3-leotimmins1974@gmail.com> <2vxzmrzlfq4e.fsf@kernel.org> <20260402111550.82c0f204ccaae2f81d584d71@linux-foundation.org> <2vxzv7e8e7om.fsf@kernel.org> <20260403102658.bc3319bc6db502e7cbfdf860@linux-foundation.org> Date: Sun, 05 Apr 2026 07:35:07 +0000 Message-ID: <2vxza4vhc11w.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sat, Apr 04 2026, Leo Timmins wrote: > Hello All, > >> Apologies for the duplicate email, I had accidentally sent it out with html instead of plain text. > > I have done my testing of Pratyush's alternate patch. My tests > indicate it successfully fixes the potential underflow if > incoming.count is <= 0 > > Patch successfully compiles with 7.0.0-rc6 and has been tested on a VM > (QEMU + VMM) with Arch. > > I executed a liveupdate with kexec which was successful. I then wrote > a test tool to replicate the underflow conditions, and added a check > to see if incoming.count is <= 0 after the if statement block > > Having confirmed it works: > > Reviewed-by: Leo Timmins Thanks! [...] -- Regards, Pratyush Yadav