From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47279366073 for ; Tue, 10 Feb 2026 14:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770732026; cv=none; b=iSjkR+CrY426ZwqyLBQ6HvcVewbCw9iDPChnBOf3eyJCRbmumDA16bb4LQ7dnYNuknVgkshxuY4aR4i8LDfzoTwjraY7za/dLL2/o/CXoPGC84Kw0dNPUTvCu6WdqWn2qLoqd82nwoCHS4GHQ4Wlb+jIDbVg7yuOT3e2baGp65E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770732026; c=relaxed/simple; bh=Qw/RiTLGCC4XlReL7wouz9nXIOGMjkMZx2I4aimv43c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=idbwOtDjvjmjgfl96pcASuP7zy4JjUZHGerGHEHV0YPWDT39AXVoiilMHKWcVSc4dfB5lCRpPFd/MFd979exXq1dbQxqrSQmYZbYPYyuUYrpLHltJoE5il9gcWzcL8s2PWP5t1MGw54m7cEB2dxOQLdFBxmsfHfu66hSoHge/Tg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PaeJ5Rit; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PaeJ5Rit" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2964CC116C6; Tue, 10 Feb 2026 14:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770732025; bh=Qw/RiTLGCC4XlReL7wouz9nXIOGMjkMZx2I4aimv43c=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PaeJ5RittgcFyauGs4iFTI03D8aARwFnljv02mb/OI32cyBI880Z0Ao7pV1jeABQD qPJaD63vKD/fQ30QyRvb9cIgbK+IKhGUOd0OAq1rT4luW3hdj+DJpKIEbOBsLumYug 2h/alC4i+oy8qxiZoguwXiJZL82N8Ac2i9ERsPk3wlncH01qZjgWXY2l6Cnuw5hBwH nQbj/jZCWMmiiMt7aw44/RyA60jSugr/IJsjhVnJ5MnVJNDmaJj/AfeN1w86NttJqm FRnKfSt/5eF6xGW5FWxFoyEbnEshogxwgeZKSNjcEE+mTk0pHdYV5PQVpTZyjAHtSv z1qVL+7jaNHQQ== From: Pratyush Yadav To: Pratyush Yadav Cc: Michal Clapinski , Evangelos Petrongonas , Pasha Tatashin , Mike Rapoport , Alexander Graf , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] kho: add support for deferred struct page init In-Reply-To: <2vxzecmssnxx.fsf@kernel.org> (Pratyush Yadav's message of "Tue, 10 Feb 2026 14:55:22 +0100") References: <20260210130418.297153-1-mclapinski@google.com> <2vxzecmssnxx.fsf@kernel.org> Date: Tue, 10 Feb 2026 15:00:22 +0100 Message-ID: <2vxza4xgsnpl.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Feb 10 2026, Pratyush Yadav wrote: > On Tue, Feb 10 2026, Michal Clapinski wrote: > >> When `CONFIG_DEFERRED_STRUCT_PAGE_INIT` is enabled, struct page >> initialization is deferred to parallel kthreads that run later >> in the boot process. >> >> During KHO restoration, `deserialize_bitmap()` writes metadata for >> each preserved memory region. However, if the struct page has not been >> initialized, this write targets uninitialized memory, potentially >> leading to errors like: >> ``` >> BUG: unable to handle page fault for address: ... >> ``` >> >> Fix this by introducing `kho_get_preserved_page()`, which ensures >> all struct pages in a preserved region are initialized by calling >> `init_deferred_page()` which is a no-op when deferred init is disabled >> or when the struct page is already initialized. >> >> Signed-off-by: Evangelos Petrongonas >> Signed-off-by: Michal Clapinski > > Reviewed-by: Pratyush Yadav (Google) Wait. I just noticed that Michal took authorship of the patch. I talked to him and he said that was by mistake. Andrew, can you please give the authorship to Evangelos when you queue the patch? -- Regards, Pratyush Yadav