From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274A33CC315 for ; Fri, 3 Jul 2026 12:03:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783080217; cv=none; b=UKh40nynamjF0f56QWB0gzCR4efv5h4hQhdInbgvtk53mn0Gf1Z7oKGavR7BbLvNdOkkxA5WrSJeENMDAEzLh6Rf1nDanpoYTGK/1APuMFDpxTsl0Pv7K/0v+a1SpTeSkaaJwtSGb+GRnjxSMP50g78j48xmLsHx9S1A3qmqVY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783080217; c=relaxed/simple; bh=wbsH5pzvSrcH89YkWGLiD+U7GX9mYJVqObjeWboHFRc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hERYf0McATZPABGEv2zYXFYhhamqeSmIIj3fqixOTTycoYym9+DDQTuzurJJ81hQJcEp/xx6Ne1ykkL4dAFBs+fWeI1niZYPHroVia/+Zf+TR5RscjkhTTxawiTRKoUupEtr2dCm2d/yNzJTDy0u6/CM25kYO1ScsJ12+icAyk8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dCCEtaSF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dCCEtaSF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4657C1F000E9; Fri, 3 Jul 2026 12:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783080215; bh=oAsxDYXFInz/u9XO8E/+whzViujYIZ7xqJPgfSxLHig=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=dCCEtaSF/82Gg+fESiFsLbe3u4kjptop+mQO1dQk2B+zmQRhm2wOS8c52WvQNZVey gc1/JGOEv+o1zfjT/lecu0W8xbfzddXrH+Qq4E9IXeuQJeSpSCZLgHoM0Uj8VZuo5H KFvryI9mSP/kSoPyqFZm3F1Nkh0gilIitZfroTW0IFWDcpUoh62b/QsUrFIEJD8fmh oPlfN0mEaDqysTk4w9dWO+45wR+Q3+4aG4wQ/mAAiXwU2em4mdKxUFatGSBk6Cj+KZ ma2yoMPueeV26/qj4Fmm1ayLZJxJFtCVS0g40tWK7yBYViejZbTR1c/N00MM/cwM21 PiNnCZteu4XPw== From: Pratyush Yadav To: mdshahid03@gmail.com Cc: Andrew Morton , Baoquan He , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , Dave Young , kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dm: crash dump: remove redundant NULL check before kvfree() In-Reply-To: <20260703112642.65498-1-mdshahid03@gmail.com> (mdshahid's message of "Fri, 3 Jul 2026 16:56:42 +0530") References: <20260703112642.65498-1-mdshahid03@gmail.com> Date: Fri, 03 Jul 2026 14:03:32 +0200 Message-ID: <2vxzbjcogu0b.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Jul 03 2026, mdshahid03@gmail.com wrote: > From: Mohammad Shahid > > kvfree() safely handles NULL pointers, so the explicit NULL check > before calling kvfree() is unnecessary. > > This issue was reported by ifnullfree.cocci. > > Signed-off-by: Mohammad Shahid Reviewed-by: Pratyush Yadav BTW, Sashiko [0] pointed out a bunch of problems in the surrounding code, and they seem to look legit. If you're interested, help in fixing them would be much appreciated. [0] https://sashiko.dev/#/patchset/20260703112642.65498-1-mdshahid03@gmail.com [...] -- Regards, Pratyush Yadav