From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91C131F1315 for ; Tue, 10 Feb 2026 13:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730297; cv=none; b=r5j4mIjDjfdt+v0fqZme6zFn1SX8p+Mf9+7hM47ZHRmw/CsPYFoxTX5fbMTOU7xaa1H5xDEbHleqYaHWFYXon8TcItBQAJ2SNU4c1BcQbn1gPvB/0pXa2svmujX/nwPm1L56pJ7qKf3fy29o0RE2nWa9+iCJ4eF+5CpjnyNItv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730297; c=relaxed/simple; bh=3HeREPRJ+703K8NPuBAJ4km2oIpg4L6gON5eMLrj2hU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=NALEkZe52iIgT2Ce1lIIAhrqJ/ymJIBcTBuEvWo0ATW7BHI0mFzUKGckc42yp+b/JXbWpmCwirRGXoXBHxeVxAaRUKqIRYA9bHCmeLGxK3JZma8mQ27KDQraFcdyNmack4tkL55evzJRZcGgcBfFdB+FQRZpbqRCETjzlQN38Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U3ioH6XU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U3ioH6XU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11841C116C6; Tue, 10 Feb 2026 13:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770730297; bh=3HeREPRJ+703K8NPuBAJ4km2oIpg4L6gON5eMLrj2hU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=U3ioH6XUgBHIUsxl3nVC5oBWbVa8bMCOGAhaOU1T/P1s1Y0TwVN4PAjCSZXmt/eka t/h9WHLgNJMsBbOQyBUWiY/9hLcAbtq9vV54GRFy0KL8/eTFJDYF3Eos8JSuVX8Bqa I70VyRN/BaJfpyo0BFMkJvJ9odH8Nn6qfVCYu8ga+kGDN0lLPIdrlE/L3hM4sVKOFY QOZXcyEz7n9M2aU2OHzouU+ER4NASWz8SZkuFM2kGMMz8o1X380LCodDte5JOTIBsF yJPDMwDYFzMvbQ0OiAmfDzbwTdXKQO+yGgqPr/rtd5j0MWLQJxLU8UlzGwWLKfCWy0 4hDKwE0+2zoPg== From: Pratyush Yadav To: Pasha Tatashin Cc: Pratyush Yadav , Mike Rapoport , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] liveupdate: luo_file: remember retrieve() status In-Reply-To: (Pasha Tatashin's message of "Sat, 31 Jan 2026 10:31:38 -0500") References: <20260126230302.2936817-1-pratyush@kernel.org> <20260126230302.2936817-3-pratyush@kernel.org> Date: Tue, 10 Feb 2026 14:31:34 +0100 Message-ID: <2vxzbjhwu3m1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Jan 31 2026, Pasha Tatashin wrote: > On Mon, Jan 26, 2026 at 6:03=E2=80=AFPM Pratyush Yadav wrote: [...] >> diff --git a/include/linux/liveupdate.h b/include/linux/liveupdate.h >> index a7f6ee5b6771..a543a3a8e837 100644 >> --- a/include/linux/liveupdate.h >> +++ b/include/linux/liveupdate.h >> @@ -21,7 +21,10 @@ struct file; >> * struct liveupdate_file_op_args - Arguments for file operation callba= cks. >> * @handler: The file handler being called. >> * @retrieved: The retrieve status for the 'can_finish / finish' > > Rename retrieved to retrieve_sts Will fix. Thanks. > >> - * operation. >> + * operation. A value of 0 means the retrieve has no= t been >> + * attempted, a positive value means the retrieve was >> + * successful, and a negative value means the retrie= ve failed, >> + * and the value is the error code of the call. >> * @file: The file object. For retrieve: [OUT] The callback= sets >> * this to the new file. For other ops: [IN] The cal= ler sets >> * this to the file being operated on. >> @@ -37,7 +40,7 @@ struct file; >> */ >> struct liveupdate_file_op_args { >> struct liveupdate_file_handler *handler; >> - bool retrieved; >> + bool retrieve_sts; >> struct file *file; >> u64 serialized_data; >> void *private_data; [...] --=20 Regards, Pratyush Yadav