From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE7F36C588 for ; Mon, 29 Jun 2026 11:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782731608; cv=none; b=UG77szsYAM7avpqsPGhMLv4+/+5aQgotxlP7tSSHsLghHYwCH3jOpREC36EjWn+2pB2Oi1WAqkM0WG4kYhjjVE7h0If76c1FYRrUVWTikKGKj1aJpKKPdpJhOFl9YdrI3abYw6KbttW84tA4NxSDNQ1tq5Q6oUP+wvKFXL22sxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782731608; c=relaxed/simple; bh=M2RodB8+UoEl8Dl1x7hBZJzesJe5L0rM12fZdMNaiXY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hjOGfN2U8i957TxOU4cF4+E9XiZdXp10aZ9ZJtwhkR1KCPvrKRkiawys1dWynKU0KfDarZLreUYMnDE3TecGUFAIulgKgUksqo/LUOMQfq5H0T6pCX6xUYZjvI6vKd8q2B4Rmh+1K6DoInqdT+Qf3UFXDL1oJRQ+F/atYC27a0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iLQsTaI1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iLQsTaI1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C36CC1F00A3A; Mon, 29 Jun 2026 11:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782731607; bh=uLo3uScFY8qXXclpLP+pID3s3N1avq1NED8H+2VbuUk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=iLQsTaI1MCOTXeeyqRet2iV2gC9t6oIsFOufNdwLP1HEYZAq+8EMcpWdneHLjc3JF eP4EeAbwxRD3u3Szfm4MvZ2JvnOkw+bPzhUyc+ppnxNcSwCpT/Ukii6MET4ZqkSEE/ q3c1r07QUvx3uMGdPPxvgF2r6x9cjm1Huyq/n2gkDtXuKGpyt/Fj6O1EGVf5TIQqwz /rJ3n0tpqAj1rp0r4ANTs2BsYufqLSHLtaQa5Rg6tnEDfdb9CAf6GPYmuGMGVjUi56 BM//ePvpqvEVv3YDFTBXsXoNQqOjWsnkZPMaxpcxdHxL5KpkV1ZfnVleiI4kHDlvGs Ay04T7GQU+icg== From: Pratyush Yadav To: Tao Liu Cc: pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, bhe@redhat.com Subject: Re: [PATCH v2] riscv: Fix a NULL pointer reference in machine_kexec_prepare In-Reply-To: <20260627222602.23594-2-ltao@redhat.com> (Tao Liu's message of "Sun, 28 Jun 2026 10:26:03 +1200") References: <20260627222602.23594-2-ltao@redhat.com> Date: Mon, 29 Jun 2026 13:13:24 +0200 Message-ID: <2vxzcxx9k3aj.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sun, Jun 28 2026, Tao Liu wrote: > A NULL pointer reference issue is noticed in riscv's machine_kexec_prepare, > where image->segment[i].buf might be NULL and copied unchecked. > > The NULL buf comes from security/integrity/ima/ima_kexec.c: > ima_add_kexec_buffer(), where kbuf is added by kexec_add_buffer(), > but kbuf.buffer is NULL. > > Fix this by simply adding a check before copy. > > Acked-by: Baoquan He > Signed-off-by: Tao Liu Acked-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav