From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73D4D3A4F58 for ; Mon, 30 Mar 2026 14:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879863; cv=none; b=GiJxH3RMrjFj9/0f4vfjxrLRfum07Lbz0XnIfg5VTZuVWkWMUnLXN65MOmQPIm+4thNEeOP5UnRjRlwYtJ8ZDS2KnAHS5irbUnmUlMtpgkO1isIflLXAOIKnJ/Qtb04ec45nCD+zKjQwIMYIASr/ctB4aCh6wZKjW7dSrvtBp5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774879863; c=relaxed/simple; bh=4im8A6qI3vNo5u1cIKaeC/wVSOXe9GnXsdheMSJcYlE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DZgciIiVLTIVdWiV/yf9mDEDPQieYL1BxFllEbpukxqyFH2Rsli+OsH8tznB3X4u95abFX3T2daC+E3Bgb6SOPO+Yp7Mhr6HCK+VjKe6s0Td+4UYk2MdgaJXZTcqQMCCwegMCvJhHuY/ISMurFQXhG91mA0sXaTB6REf2wtYwCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VGwELGrJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VGwELGrJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AE70C4CEF7; Mon, 30 Mar 2026 14:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774879863; bh=4im8A6qI3vNo5u1cIKaeC/wVSOXe9GnXsdheMSJcYlE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VGwELGrJxZKgimq0j6OK2Mhv+JpXJcad7vWxpMxVQlCa8qfyatgpb4bDfBMU/JWyA DVQFhMvsSuZHabwRvtiv+zkke6X1buHyH5hIvGOXj4rvSfHeFBNCR1EYBkHYntc+ow vSwfiVHqRFFHtPH+8j6arS/JPlFEM4PelCc+awDxl5AclaLxN2lCiw49T8ZmFaKk/G DVKI4xvZGXS7SRU6PDPdfAY1aIibwD/YMS8XxXkXGbAYIv+HmfHNT9vk9YdSIm0Mtc VKYmBbgkN7/i9a+1PKNZELBRe4xPYaMM2mRiYwjomtI3mwkn+vGkL437E/nzAfzbti r6LmcNRGrKsxA== From: Pratyush Yadav To: Eliav Farber Cc: , , , , , , , Subject: Re: [PATCH v2 0/3] mtd: spi-nor: winbond: Fix protection handling In-Reply-To: <20260218143523.17467-1-farbere@amazon.com> (Eliav Farber's message of "Wed, 18 Feb 2026 14:35:20 +0000") References: <20260218143523.17467-1-farbere@amazon.com> Date: Mon, 30 Mar 2026 14:10:59 +0000 Message-ID: <2vxzcy0l1k7g.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Feb 18 2026, Eliav Farber wrote: > This series fixes block protection handling for the following Winbond > SPI-NOR devices: > - w25q256jwm > - w25q256jw > - w25q64jvm > > The devices do not correctly describe their Status Register layout and > protection capabilities (locking flags, TB bit, BP bit configuration). > As a result, the spi-nor core rejects protection requests and locking > operations fail with -EINVAL, e.g.: > > flash_lock -l /dev/mtd29 > flash_lock: error!: could not lock device: /dev/mtd29 > error 22 (Invalid argument) > > Update the device flags to match the actual hardware behavior so that > locking and unlocking regions work correctly. > > All changes were validated using flash_lock on the affected devices. Applied patches 1 and 3 to spi-nor/next. Thanks! Skipped patch 2 since you say that you haven't got a device to test with. I don't have a very strong opinion on this, but I do think we should test patches on real hardware just to we get some sanity checking for the patch. [...] -- Regards, Pratyush Yadav