From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC5C51E47C5 for ; Mon, 26 Jan 2026 13:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769434508; cv=none; b=ccs+muMhnzNkyzgbS1wdWONGqoTEhL0h/3qSoA3zh/eiecbakChtGgo/7j6ekdi5MB4jDIoWdImukRoL+c4yawAt09YNhWGfyGIiC4v3nFuv2sbRFekrMVIUZE2Zhwr24YNdDyWnqSNYdNqOc5Kzr0iDtDWlF/q9VnY4HTfcm8M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769434508; c=relaxed/simple; bh=lBIMffzY+AoU7PgBcVkFtZWf5SUwXZYGLlR6MmjFL0I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=VxCoO1w6wbzR7j07a1f8UY9/GTpoLP97ABDhFV2mA6qIpbnMPLm7bJ6xpPXY4Gvcqp5QHSSFspol6DqM5Dqnf0v+wzAcPuUhTi+RQefKp9yZNxkFby3JmIA8v5Ew+QYcMiq/7fJEbrVrIc/tyW2d+k+VRQegOzsMtamwUKQhoP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ujPNyDAl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ujPNyDAl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05144C116C6; Mon, 26 Jan 2026 13:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769434508; bh=lBIMffzY+AoU7PgBcVkFtZWf5SUwXZYGLlR6MmjFL0I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ujPNyDAlvmvq1uH3VAd4uhLhXWSRnpoMj/JhFhOM6dOhkRkZ+oIJRfhA5OzcIiSAN +pd7/+GMCZQDqdQh3l2OZ+xvcaTMePLQ3TlozpebC7q3WoEPrC1Gy8ZseQfjBoMdJ1 3mVShCMAnwfpRtPIOdTUntFgYHV5bpBiIPyu6HG30utiRcn/8Skq41nixqSwVk8f3y RLoOW/ZbEIqly2xRmvM9JyROZtrdHpfmmBo9+O8htLanBmbQRN9J7e9LOe1ZV6K3lk 27v51ZExeMjOcmUUZ8/nMGmoAQDOfpwuQZ0+r8UIyOVsaBt0GF5d3J4WpGL6dQ95ca LaPDpL/aTbRnw== From: Pratyush Yadav To: Breno Leitao Cc: Alexander Graf , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, usamaarif642@gmail.com, rmikey@meta.com, clm@fb.com, riel@surriel.com, kernel-team@meta.com, SeongJae Park Subject: Re: [PATCH v4] kho: kexec-metadata: track previous kernel chain In-Reply-To: <20260121-kho-v4-1-5c8fe77b6804@debian.org> (Breno Leitao's message of "Wed, 21 Jan 2026 06:50:38 -0800") References: <20260121-kho-v4-1-5c8fe77b6804@debian.org> Date: Mon, 26 Jan 2026 14:35:04 +0100 Message-ID: <2vxzecnca453.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Breno, On Wed, Jan 21 2026, Breno Leitao wrote: > Use Kexec Handover (KHO) to pass the previous kernel's version string > and the number of kexec reboots since the last cold boot to the next > kernel, and print it at boot time. > > Example output: > [ 0.000000] KHO: exec from: 6.19.0-rc4-next-20260107 (count 1) > > Motivation > ========== > > Bugs that only reproduce when kexecing from specific kernel versions > are difficult to diagnose. These issues occur when a buggy kernel > kexecs into a new kernel, with the bug manifesting only in the second > kernel. > > Recent examples include the following commits: > > * eb2266312507 ("x86/boot: Fix page table access in 5-level to 4-level paging transition") > * 77d48d39e991 ("efistub/tpm: Use ACPI reclaim memory for event log to avoid corruption") > * 64b45dd46e15 ("x86/efi: skip memattr table on kexec boot") > > As kexec-based reboots become more common, these version-dependent bugs > are appearing more frequently. At scale, correlating crashes to the > previous kernel version is challenging, especially when issues only > occur in specific transition scenarios. > > Implementation > ============== > > The kexec metadata is stored as a plain C struct (struct kho_kexec_metadata) > rather than FDT format, for simplicity and direct field access. It is > registered via kho_add_subtree() as a separate subtree, keeping it > independent from the core KHO ABI. This design choice: > > - Keeps the core KHO ABI minimal and stable > - Allows the metadata format to evolve independently > - Avoids requiring version bumps for all KHO consumers (LUO, etc.) > when the metadata format changes > > The struct kho_metadata contains two fields: > - previous_release: The kernel version that initiated the kexec > - kexec_count: Number of kexec boots since last cold boot > > On cold boot, kexec_count starts at 0 and increments with each kexec. > The count helps identify issues that only manifest after multiple > consecutive kexec reboots. > > Signed-off-by: Breno Leitao > Acked-by: SeongJae Park [...] > diff --git a/include/linux/kho/abi/kexec_handover.h b/include/linux/kho/abi/kexec_handover.h > index 285eda8a36e45..e18022a4e664d 100644 > --- a/include/linux/kho/abi/kexec_handover.h > +++ b/include/linux/kho/abi/kexec_handover.h > @@ -11,6 +11,7 @@ > #define _LINUX_KHO_ABI_KEXEC_HANDOVER_H > > #include > +#include > > /** > * DOC: Kexec Handover ABI > @@ -84,6 +85,34 @@ > /* The FDT property for sub-FDTs. */ > #define KHO_FDT_SUB_TREE_PROP_NAME "fdt" > > +/** > + * DOC: Kexec Metadata ABI > + * > + * The "kexec-metadata" subtree stores optional metadata about the kexec chain. > + * It is registered via kho_add_subtree(), keeping it independent from the core > + * KHO ABI. This allows the metadata format to evolve without affecting other > + * KHO consumers. > + * > + * The metadata is stored as a plain C struct rather than FDT format for > + * simplicity and direct field access. > + */ > + > +/** > + * struct kho_kexec_metadata - Kexec metadata passed between kernels > + * @previous_release: Kernel version string that initiated the kexec Other than Mike's comments, I only have a small nitpick. Please add a comment here that using __NEW_UTS_LEN in the ABI is safe here since it is a part of UAPI. LGTM otherwise. > + * @kexec_count: Number of kexec boots since last cold boot > + * > + * This structure is preserved across kexec and allows the new kernel to > + * identify which kernel it was booted from and how many kexec reboots > + * have occurred. > + */ > +struct kho_kexec_metadata { > + char previous_release[__NEW_UTS_LEN + 1]; > + u32 kexec_count; > +} __packed; > + [...] -- Regards, Pratyush Yadav