From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABDD238A72B for ; Tue, 9 Jun 2026 15:54:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781020468; cv=none; b=nFCbl3z1g+HxgictzzvchPFGh4K/A8zDcX+2V8l3XwUJmOurAmd1kSVBEmi3CIH1qANzClMnyhSwX646xL4pkDYo5EXOj5CQZE/emxFPdKbU/6HxR6XIJkksyKPaVJhMoxvcoY3k8SwJfWYvCDDqoUi1iZp7qeR9PcL5h9eujP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781020468; c=relaxed/simple; bh=sxwT3+y/RoC97dBZV5GQ6JVjqOBqqDXYx23hYxyU8uk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ppj/KAb1RdxTgbo0F/l+oLCtodePF51ppjLOtqeJrvCWOHoZnqqwGy0OKVDuTVEFttdxoowuOdWD0bu3IJjVM9uokQPdJBIqGzAGD1avCX8lCwEaR4uUcpzVkBFkqxDYmnZo5/PRzA2oGY1GdOb40+pAqAIQHKuaLqNEJQFHZPc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FCCLI2U2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FCCLI2U2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3083E1F00893; Tue, 9 Jun 2026 15:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781020467; bh=bmKlnOdHqjNiU96gwk50EppMlrDvFXPS7Xmukl/T8Zs=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FCCLI2U2SPrU+pm+d906hK32RXBqM3qMdXXLPhwztHqlJ60VL06KZzqm/31dUoKF1 ffgAYCDLbven+3j9WrH20VH5Xt/8ZRzDDqygbNjmMMiM+5hJ/IM2Jjq/1W3ARu/FwX 28ShegM38hUgJwkXBgvH3lrIQr3zc9veW+Rc4AYHmN0wpD3wFnvHBAFx7XNn1GDLlH BqlT2/2DQWHSD8QTByN9VJPCFKT9QfM6KlH+3qbpY+X3qHj7KtkWSB2Zu8ilAwxP49 prGXgDIqgjqX2cOGM5dSHFhiXgjX4U6SUBu/hWsL7YRpaC2b4ujSvBwFnsBNXU5+EU b5f/CkITWnlZA== From: Pratyush Yadav To: Tarun Sahu Cc: Pasha Tatashin , Mike Rapoport , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, vipinsh@google.com Subject: Re: [PATCH] liveupdate: Document that retrieve failure is permanent In-Reply-To: <074445fc4964961f12171ea129f2a7690322a78a.1780944056.git.tarunsahu@google.com> (Tarun Sahu's message of "Mon, 8 Jun 2026 18:42:50 +0000") References: <074445fc4964961f12171ea129f2a7690322a78a.1780944056.git.tarunsahu@google.com> Date: Tue, 09 Jun 2026 17:54:24 +0200 Message-ID: <2vxzfr2vso9b.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Jun 08 2026, Tarun Sahu wrote: > Signed-off-by: Tarun Sahu > --- > include/uapi/linux/liveupdate.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h > index 30bc66ee9436..a564d2bd05c1 100644 > --- a/include/uapi/linux/liveupdate.h > +++ b/include/uapi/linux/liveupdate.h > @@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd { > * associated with the token and populates the @fd field with a new file > * descriptor referencing the restored resource in the current (new) kernel. > * This operation must be performed *before* signaling completion via > - * %LIVEUPDATE_IOCTL_FINISH. > + * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status > + * is saved. So it is permanent failure and retry is pointless. Perhaps the wording below is slightly better from a user perspective? If a retrieve of a token fails, subsequent attempts to retrieve the token fail with the same error code. Failed retrieves are not retried. > * > * Return: 0 on success, negative error code on failure (e.g., invalid token). > */ > > base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce > prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17 -- Regards, Pratyush Yadav