From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7331426688 for ; Mon, 11 May 2026 16:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517620; cv=none; b=gy+cglgMBV60dAx0GiWK5NIc5XkIKAK5tR7x9smCkyT5WfYnZsGfnalbrIAG6lSvw+7+nvrT0wj+CaLCJQh6jajiQ55etGS+DES66SN/IS1k2tBJlrArtrhHsg39WlqQjQOCTV28PIDlRTCsOG0vOPOSF0nf2tvFSaX0LT4RcK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778517620; c=relaxed/simple; bh=5Sy2Vpv0vDIpYFu4ImjlfBjTqwz0lLOoa+OwNsUw6hM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ncPED7jsC/KBBicpUD+oVkyE4hE17Qsodm/gdSnw83qeTRt6+9bF0M/lqbyBu7D2eptqJMCKKbbAVwCLKzhTOX26T5LQ0pENnYcTTIkqzaQc/Fn2xh0hs1SFhbCyTWkB8utxJUCZi86+e+EsvAqOlRxGHgKtzl58pte3hlxTSBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Aoe08CUr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Aoe08CUr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55F20C2BCB0; Mon, 11 May 2026 16:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778517620; bh=5Sy2Vpv0vDIpYFu4ImjlfBjTqwz0lLOoa+OwNsUw6hM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Aoe08CUrjB1qKN3KIDK0zQ4/hDTZrmcaQTUPmLyK/bHWKwjdgnKG9VepTO99yXigc UVChFCzbF1NI2uUpK/V9Um916/iJYf+MSkaqlMCzF3V/FYtDsXSCESVRCfQ55sRzNb vBSTPTAGj8Usif7Iwdh4XNMm9ephMs8oPo2S6Tya+XxGJE1fKp6t7/X0WAYXkRqPAa KczkmzTbCbOhyZWcoCyZeyT7WLBr82JP+O349v+7o0ZAA1tLHlSjCfsiou/zpafqk2 BRDlbEp+74njsAGBlzDGlyYgufscXlxRMGJI79qCw1P8hKDdWtCvEi++awc1nAVdip 0BAN09OnXzfJg== From: Pratyush Yadav To: Pratyush Yadav Cc: Mike Rapoport , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/12] kho: add callback for table pages In-Reply-To: <2vxzv7ctc38a.fsf@kernel.org> (Pratyush Yadav's message of "Mon, 11 May 2026 18:36:53 +0200") References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-5-pratyush@kernel.org> <2vxzv7ctc38a.fsf@kernel.org> Date: Mon, 11 May 2026 18:40:16 +0200 Message-ID: <2vxzik8tc32n.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, May 11 2026, Pratyush Yadav wrote: > On Mon, May 11 2026, Mike Rapoport wrote: > >> On Wed, Apr 29, 2026 at 03:39:06PM +0200, Pratyush Yadav wrote: >>> From: "Pratyush Yadav (Google)" >>> >>> The KHO memory preservation radix tree does not mark the table pages >>> themselves as scratch. This is done to avoid a circular dependency where >>> preserving a page can lead of allocating other preserved pages. This >>> means any walker looking for free ranges of memory outside of scratch >>> areas will ignore the table >>> >>> Add a table callback that is invoked for each table page. The callback >> >> A sentence why a table callback helps would be nice here :) > > The main reason is that a later patch will create a radix tree for short > use and will need to destroy it afterwards. This was meant for patch 7. The reason for this one is that kho_extend_scratch() needs to exclude table pages from its free ranges. Will add it. > > Will add that here. > >> >>> is given the physical address of the table page. >>> >>> Signed-off-by: Pratyush Yadav (Google) -- Regards, Pratyush Yadav