From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D09D3B103B for ; Thu, 30 Jul 2026 11:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412239; cv=none; b=R8SBo/vw5tSy7BKhuT0eRJEXkuzJxVr3uXqnGdFicDfDPYbfxeZyUipMciQE5jsJrLvKJzpu9pTfmEnWJ5NQ8ZbFj4Tk3zMDr+jswgo+T8vvzpUKg0f6vWqZzoXG4BY0jgORQaJHIImO8QHgzGowWJ6z/u5FC8VqTp5ATgjcWcU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785412239; c=relaxed/simple; bh=FA2P8LuqwRuzm1aZ84NE3UlHYp+1j18l+JsJvQooWRo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=p5O32MvjOqzYutQHULOfclFhaDdqfWBvaI5p69vY6Hv8mMQLh2XXQtcBKa2WghywAeGeQ6yAXoFIsguheIuPgjrnjXP5dBjCFIRLPfLVmo+yeqCUcvqG/v6UWcgO/LY8Cpobvhh59yUS6RrDyx16My9xxGO8pJFUW0K82aVM/X8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VFxavYoI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VFxavYoI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBE7A1F00A3A; Thu, 30 Jul 2026 11:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785412237; bh=2x/3afnS5nA1+U4o3Wmcac5daCL5SWJ0JULSmSn8Nlg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=VFxavYoID/H1SY3p3HdWy6FGgQHd/Sc3WjhPk+qvd7eOlGYPzkZo8IULG3d/Yrb8P iOx/Wkl/68RIeETIGvf7cm8dC2UMMZ1wbyKxqav0vNGc9eoTVdOAhOwg99eCoZoam6 owNFEC3JwnEO30HkW3uOqO3ALOkSiuWzjNwwrPM7x7Xh2Qa+Jq54B6PD4TnGKro+eB C51nzZV87/Yb4XRcHdWeJMx88WWTlnurt6kNXm8tFVuB5MOzOYw0dWFZNf3afQuQJM 7a05sBj0fVAfgP7CAnAZkdt9liUQ6j5fgy6hfRYcbaazkXrGsBQWYwKLS3WZW7s6c0 KGY7i8A1ouf5A== From: Pratyush Yadav To: Mike Rapoport Cc: Pratyush Yadav , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , Jork Loeser , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/22] kho: generalize radix tree APIs In-Reply-To: (Mike Rapoport's message of "Thu, 30 Jul 2026 11:40:23 +0300") References: <20260729145610.2827231-1-pratyush@kernel.org> <20260729145610.2827231-2-pratyush@kernel.org> Date: Thu, 30 Jul 2026 13:50:34 +0200 Message-ID: <2vxzmrv87l2t.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Jul 30 2026, Mike Rapoport wrote: > On Wed, Jul 29, 2026 at 04:55:46PM +0200, Pratyush Yadav wrote: >> From: "Pratyush Yadav (Google)" >> >> Generalize the APIs by taking the key directly and doing the encoding at >> the callers. Rename the functions to kho_radix_add_key() and >> kho_radix_del_key(). In practice, this removes a line each from the >> functions and moves the encoding function call to the callers. >> Similarly, update kho_radix_tree_walk_callback_t to take the key >> directly. >> >> diff --git a/include/linux/kho_radix_tree.h b/include/linux/kho_radix_tree.h >> index 84e918b96e53..f368f3b9f923 100644 >> --- a/include/linux/kho_radix_tree.h >> +++ b/include/linux/kho_radix_tree.h >> @@ -34,30 +34,24 @@ struct kho_radix_tree { >> struct mutex lock; /* protects the tree's structure and root pointer */ >> }; > > sashiko: This isn't a bug, but did you miss updating the kerneldoc for > struct kho_radix_tree? That's new, sashiko didn't find this on v4... > > And indeed "DOC: Kexec Handover Radix Tree" talks about addresses and > orders. Yep, will fix for v6. -- Regards, Pratyush Yadav