From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 297E43BF682 for ; Tue, 14 Apr 2026 09:35:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776159349; cv=none; b=kEf4eJecirq3fQP6muLIOqxdehKQ9RQPiZeOEQZ5gzbWoiFEWDQUivTS1rEoay6X14OiydkH2FOE6n9pDL7qiM2dnJX+KjE4E9vzD+eYDB9up58YvvDdTMYKDeUPmJ3k4wcw5nht/uNJaDGzBDFX/Wu3wbxBona0RGuEy1keTmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776159349; c=relaxed/simple; bh=GQcAgbM3J373532SPtusBvcSD/X5zsXVrZEqHzWWWx4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=u41muOgdveMTZXBBcG8dh/ngJIwh/rPHlFPomOSoFxW1f3uhyV3ShYkmiipQbL01qZJphUVW8/vlEuF1dnKcM+YuXcxGwE1TqUhYfsTKQ98av8500vPNFBo36WP2NUDEVgubRg7bdeaFtwKFR2W1CfvEfwRvSxFsMh4XlwBjfdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A+opRLf2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A+opRLf2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B375C19425; Tue, 14 Apr 2026 09:35:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776159348; bh=GQcAgbM3J373532SPtusBvcSD/X5zsXVrZEqHzWWWx4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A+opRLf2qNjapfjlaE3JjURGvDtRYL7JDCQXA6w/F9BkkCWGcsbOC0e6yRwbsvpgD WncjQxDTDm2+L7JapQIFXYejhKLhlzgbbzYDu3PwnWbTJU4obrByJ3A0tXV5bXpRfu Fb7h4kBw5/gloA6NR/5yGa6Ya7wFnIgbmtGeEdjmw8tiJAcqJk1Fc93yii2rUII/fW 6S5yt77W64d7IZzQp7F+h+DwWNGsLiAXdXMUpYbcSnadxGLxyyHkK51waKACQy8WTg GNaFeNFD+G/TLQckxZeaC1AmPUd1baRi81esUDpLokE84Q5GjZVTw8e4SPsVciR3Bv FnFIjjdTwcKGg== From: Pratyush Yadav To: Pasha Tatashin Cc: rppt@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dmatlack@google.com, pratyush@kernel.org, skhawaja@google.com Subject: Re: [PATCH v4 11/11] liveupdate: fix return value on session allocation failure In-Reply-To: <20260413185127.128180-12-pasha.tatashin@soleen.com> (Pasha Tatashin's message of "Mon, 13 Apr 2026 18:51:27 +0000") References: <20260413185127.128180-1-pasha.tatashin@soleen.com> <20260413185127.128180-12-pasha.tatashin@soleen.com> Date: Tue, 14 Apr 2026 09:35:45 +0000 Message-ID: <2vxzmrz5995a.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Apr 13 2026, Pasha Tatashin wrote: > When session allocation fails during deserialization, the global 'err' > variable was not updated before returning. This caused subsequent calls > to luo_session_deserialize() to incorrectly report success. > > Ensure 'err' is set to the error code from PTR_ERR(session). This > ensures that an error is correctly returned to userspace when it > attempts to open /dev/liveupdate in the new kernel if deserialization > failed. > > Signed-off-by: Pasha Tatashin Reviewed-by: Pratyush Yadav (Google) [...] -- Regards, Pratyush Yadav