From: Pratyush Yadav <pratyush@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Alexander Graf <graf@amazon.com>,
Mike Rapoport <rppt@kernel.org>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-mm@kvack.org, usama.arif@linux.dev,
SeongJae Park <sj@kernel.org>,
kernel-team@meta.com
Subject: Re: [PATCH v9 4/6] kho: fix kho_in_debugfs_init() to handle non-FDT blobs
Date: Fri, 03 Apr 2026 11:27:58 +0000 [thread overview]
Message-ID: <2vxzmrzkcmgx.fsf@kernel.org> (raw)
In-Reply-To: <20260316-kho-v9-4-ed6dcd951988@debian.org> (Breno Leitao's message of "Mon, 16 Mar 2026 04:54:34 -0700")
On Mon, Mar 16 2026, Breno Leitao wrote:
> kho_in_debugfs_init() calls fdt_totalsize() to determine blob sizes,
> which assumes all blobs are FDTs. This breaks for non-FDT blobs like
> struct kho_kexec_metadata.
>
> Fix this by reading the "blob-size" property from the FDT (persisted
> by kho_add_subtree()) instead of calling fdt_totalsize(). Also rename
> local variables from fdt_phys/sub_fdt to blob_phys/blob for
> consistency with the non-FDT-specific naming.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
[...]
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2026-04-03 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 11:54 [PATCH v9 0/6] kho: history: track previous kernel version and kexec boot count Breno Leitao
2026-03-16 11:54 ` [PATCH v9 1/6] kho: add size parameter to kho_add_subtree() Breno Leitao
2026-04-03 11:21 ` Pratyush Yadav
2026-03-16 11:54 ` [PATCH v9 2/6] kho: rename fdt parameter to blob in kho_add/remove_subtree() Breno Leitao
2026-03-16 11:54 ` [PATCH v9 3/6] kho: persist blob size in KHO FDT Breno Leitao
2026-04-03 11:24 ` Pratyush Yadav
2026-03-16 11:54 ` [PATCH v9 4/6] kho: fix kho_in_debugfs_init() to handle non-FDT blobs Breno Leitao
2026-04-03 11:27 ` Pratyush Yadav [this message]
2026-03-16 11:54 ` [PATCH v9 5/6] kho: kexec-metadata: track previous kernel chain Breno Leitao
2026-04-03 11:29 ` Pratyush Yadav
2026-03-16 11:54 ` [PATCH v9 6/6] kho: document kexec-metadata tracking feature Breno Leitao
2026-04-03 11:33 ` [PATCH v9 0/6] kho: history: track previous kernel version and kexec boot count Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2vxzmrzkcmgx.fsf@kernel.org \
--to=pratyush@kernel.org \
--cc=graf@amazon.com \
--cc=kernel-team@meta.com \
--cc=kexec@lists.infradead.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=usama.arif@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox