From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620D53AE1B1 for ; Fri, 3 Apr 2026 11:28:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215683; cv=none; b=sjVIK7WksHiADkJ+hmsGTijGD1i2vZrhLS4bhpIR3gndJY9QpfBwbUk54vnpfGfo7dAGOxkmuXTxD1HJCypsq3O3bWd4NqkayrDByALEBRFh5UHWzyu9tZsyM7X5TOTC/wRHHBi78WXPWsLVz3i0ylSwjj3K8sUMCkk0zP+lJfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215683; c=relaxed/simple; bh=MabZ8ZNxlfCbCNmRDlhcdrRriNXoWOt9AGIbHCeoMZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Tv5HJiGFgueSVu/lT5i4zdwKYrZHv+E5lrkRkH4+PooWVBn/9bsfkNoD+ZGVly7+7q0kCvdyi4l3Ip42NsdYpaPfCBA86zZY7egyxZsEIHWOedlz87NjaEbqDHeMu6vAuGn/YWuWSqU53UTfFwPeUqWYotD2Tu/jjpIsGcFE7EU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uBvAbrlT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uBvAbrlT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA9EC4CEF7; Fri, 3 Apr 2026 11:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775215682; bh=MabZ8ZNxlfCbCNmRDlhcdrRriNXoWOt9AGIbHCeoMZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=uBvAbrlTeTRt2+30VJbA5n2wjqDEx6Y995UcLZKvOhxPUEqt9Ea/BEaDo7MYuOO/8 vEKvhY+w8cpNON5DPGwQsrTq9Uw0YWxNLCfXZUH+vLLwKGTpVsChEZSNF4sN4I56cC ES0kSoQhuSWJt4anekYaIuTx2YLkGbKvhTRR+gQtItlkZZf4p89S1bdMdaO+/9moZB vUXSW5X0CexGi0LLcIdzFf3PzgAL/zkFbJr9QyllIdBwUxg2CYoRMKrnzhU9LBQ+G6 6CDpwqeU9YncpUaRpYDJnG1EjWwqp185HKLkSNniPBj7PNu6Tst0FThD0l8Et1Ksse Q97kGfkJHKfkg== From: Pratyush Yadav To: Breno Leitao Cc: Alexander Graf , Mike Rapoport , Pasha Tatashin , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org, usama.arif@linux.dev, SeongJae Park , kernel-team@meta.com Subject: Re: [PATCH v9 4/6] kho: fix kho_in_debugfs_init() to handle non-FDT blobs In-Reply-To: <20260316-kho-v9-4-ed6dcd951988@debian.org> (Breno Leitao's message of "Mon, 16 Mar 2026 04:54:34 -0700") References: <20260316-kho-v9-0-ed6dcd951988@debian.org> <20260316-kho-v9-4-ed6dcd951988@debian.org> Date: Fri, 03 Apr 2026 11:27:58 +0000 Message-ID: <2vxzmrzkcmgx.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Mar 16 2026, Breno Leitao wrote: > kho_in_debugfs_init() calls fdt_totalsize() to determine blob sizes, > which assumes all blobs are FDTs. This breaks for non-FDT blobs like > struct kho_kexec_metadata. > > Fix this by reading the "blob-size" property from the FDT (persisted > by kho_add_subtree()) instead of calling fdt_totalsize(). Also rename > local variables from fdt_phys/sub_fdt to blob_phys/blob for > consistency with the non-FDT-specific naming. > > Signed-off-by: Breno Leitao Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav