From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC39023AB9D for ; Fri, 13 Mar 2026 10:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773396130; cv=none; b=l8F4z4sdsPtTy3mpVZtRNZyRW9URjatYR3uA/QEtAhkmC4cKBU+AdpnCAAl+eOUQhgjRI7WhK28ZURygz0iIf/LD++5ggifQEpF2CrKNT17Ixtneh+0Py1QvJDrihO/nsBNBLi7ysJM8canQWLK/hBY8lawJ7nyGXyGCRMlvaDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773396130; c=relaxed/simple; bh=8xebjfiBVxR3eAmwaXvUzEUUqxYWZT+mF9mD9gGzH+0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=eSC8lLRPcDk9BB7n6vDmIWHal/VrNKdsf7hzgM/s3ukdswSEsgvoF97O0hJjNFXlc534+E7y5BqemFOxAcjrOGFo6LCzJPcRjAxjR5Lb7xHi1G/rL7wnqwKjVY1aWME2pAnPmwsJP6oX1mBznBt0Oyftylz4fxhBdSw0Fp8GXTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i4SxGu4+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i4SxGu4+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E20DC19421; Fri, 13 Mar 2026 10:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773396130; bh=8xebjfiBVxR3eAmwaXvUzEUUqxYWZT+mF9mD9gGzH+0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=i4SxGu4+nLEFTuli1oHszcAtRfooGgHAuAJAdAdEgo9O0Fv5JEdfV7MCZT1J6oxCk fFkBxlaZGVZ6BUK0hF6Z1NKTIoYyacqhmlCbPzZPRKNj18+s8JD70NmV6bW7G+apsR g1N8A9P0nBLP/mU5sO9B9QbakkEj1oK3vBSEYj3Bcw2NLuGkjA7yAH812TMoIm9LAR jpIHI+4NpI1PNiihendZX5e8GuSG/3cRoHOMCGW4GkMK3K/TvmeYK8daT/JHb+CBkC YVo+0qe0lF+9/ulWgP6u6aiSjIDPyh2+aIoncaOgppfas5X0Aq31fyJK2+E/GmCjjY abAFhwln3lmxQ== From: Pratyush Yadav To: ranxiaokai627@163.com Cc: graf@amazon.com, akpm@linux-foundation.org, rppt@kernel.org, pratyush@kernel.org, pasha.tatashin@soleen.com, jasonmiu@google.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, ran.xiaokai@zte.com.cn, Breno Leitao Subject: Re: [PATCH] kho: fix child node parsing for debugfs in/sub_fdts In-Reply-To: <20260309033530.244508-1-ranxiaokai627@163.com> (ranxiaokai's message of "Mon, 9 Mar 2026 03:35:30 +0000") References: <20260309033530.244508-1-ranxiaokai627@163.com> Date: Fri, 13 Mar 2026 10:02:06 +0000 Message-ID: <2vxzpl58f3oh.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Mon, Mar 09 2026, ranxiaokai627@163.com wrote: > From: Ran Xiaokai > > Commit e0c1731f5d57 ("kho: adopt radix tree for preserved memory tracking") > changed KHO_FDT_SUB_TREE_PROP_NAME from "fdt" to "preserved-data". However, > kho debugfs code still hard-coded the "fdt" string when parsing the > device tree, causing the debugfs node /debugfs/kho/in/sub_fdts/ > fail to parse child nodes correctly. > > Fix this by including the header file and using KHO_FDT_SUB_TREE_PROP_NAME > instead of the hard-coded string. > > Fixes: e0c1731f5d57 ("kho: adopt radix tree for preserved memory tracking") > Signed-off-by: Ran Xiaokai Breno's patch [0] also fixes this, but I'd rather have this go through hotfixes and get backported to stable, and Breno's series to build on top of this. [0] https://lore.kernel.org/linux-mm/20260309-kho-v8-4-c3abcf4ac750@debian.org/ Reviewed-by: Pratyush Yadav > --- > kernel/liveupdate/kexec_handover_debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/liveupdate/kexec_handover_debugfs.c b/kernel/liveupdate/kexec_handover_debugfs.c > index 3f395fbd978f..acf368222682 100644 > --- a/kernel/liveupdate/kexec_handover_debugfs.c > +++ b/kernel/liveupdate/kexec_handover_debugfs.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include "kexec_handover_internal.h" > > static struct dentry *debugfs_root; > @@ -121,7 +122,7 @@ __init void kho_in_debugfs_init(struct kho_debugfs *dbg, const void *fdt) > const char *name = fdt_get_name(fdt, child, NULL); > const u64 *fdt_phys; > > - fdt_phys = fdt_getprop(fdt, child, "fdt", &len); > + fdt_phys = fdt_getprop(fdt, child, KHO_FDT_SUB_TREE_PROP_NAME, &len); > if (!fdt_phys) > continue; > if (len != sizeof(*fdt_phys)) { -- Regards, Pratyush Yadav