public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <pratyush@kernel.org>
To: "Yanjun.Zhu" <yanjun.zhu@linux.dev>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	 pasha.tatashin@soleen.com, rppt@kernel.org,  shuah@kernel.org,
	 linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/1] selftests/liveupdate: Cleanup kernel optio CONFIG_LIVEUPDATE_TEST
Date: Thu, 12 Feb 2026 14:01:09 +0100	[thread overview]
Message-ID: <2vxzpl6aqfoq.fsf@kernel.org> (raw)
In-Reply-To: <51f77faa-5d8b-4e8b-8cfd-04ae06726864@linux.dev> (Yanjun Zhu's message of "Tue, 10 Feb 2026 10:15:07 -0800")

On Tue, Feb 10 2026, Yanjun.Zhu wrote:

> On 2/10/26 5:36 AM, Pratyush Yadav wrote:
>> On Thu, Jan 29 2026, Zhu Yanjun wrote:
>>
>>> 在 2026/1/29 20:28, Zhu Yanjun 写道:
>>>> The kernel option CONFIG_LIVEUPDATE_TEST does not exist currently.
>>>> Remove it.
>>> In kernel 6.19-rc7, this kernel option still exists in the file
>>>
>>> tools/testing/selftests/liveupdate/config. Thus I send out this commit to remove
>>> it.
>> Yes, but the patch to add the config is in mm-nonmm-unstable. I am not
>> sure if this worth the churn of removing this and re-adding it when that
>> patch lands later. Do you see a real problem with this?
> Thanks for the feedback.
>
> I understand that the patch adding this functionality is currently in
> mm-nonmm-unstable. My concern was primarily adhering to the documentation, which
> suggests keeping the kernel configs pruned of unused options to avoid confusion
> for those running selftests.
>
> However, I see your point regarding the churn. If you prefer, we can wait until
> the mm-nonmm-unstable branch is merged into the mainline. Once that happens, if
> this option remains truly redundant or if the implementation changes, I can
> resubmit the cleanup then.
>
> Does that sound like a reasonable compromise to you?

Yes, sounds good. And even though I don't recommend taking this patch
right now, the effort to keep things clean is much appreciated!

-- 
Regards,
Pratyush Yadav

      reply	other threads:[~2026-02-12 13:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30  4:28 [PATCH 1/1] selftests/liveupdate: Cleanup kernel optio CONFIG_LIVEUPDATE_TEST Zhu Yanjun
2026-01-30  4:31 ` Zhu Yanjun
2026-02-10 13:36   ` Pratyush Yadav
2026-02-10 18:15     ` Yanjun.Zhu
2026-02-12 13:01       ` Pratyush Yadav [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2vxzpl6aqfoq.fsf@kernel.org \
    --to=pratyush@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=yanjun.zhu@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox