From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D552204C3B; Fri, 3 Jul 2026 14:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090794; cv=none; b=OH/RdAvov/ai9wq3jQJtQ1/t9o+C6wtcSrvXlritITwiiJFL81/2TNF69hC5Vu9VzIi4EJvKdNAEz1+JR1BDNIgsjecFz8WFo225sRCXCdmA6okd5Y4PcVUr8T0vdiluurxM1k7bJoJHslwzVn9VuzfELrxVGt1365I6cTuzUGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783090794; c=relaxed/simple; bh=iszMYG8/GDwOkWSLEKylfXpVUW/SGclSH7eygKWPKWU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=aV5NRhFAkWd9dcdLHVGKFdbn7EfT1/aSOsiAMbXcbDLD4LH6jdqvB24EzOzVGTt9cDnWcDFf5I2ovvlZnrrFcgvpQg4uz/nKTQzvYwLTCQhZ32qX4RJjGHDQNS1bkA6kIQsrYkruZwUMV8cvJZl+FgPYMqVxcCJD9112PJrMrck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A42/s2/b; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A42/s2/b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02D9A1F000E9; Fri, 3 Jul 2026 14:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783090793; bh=iszMYG8/GDwOkWSLEKylfXpVUW/SGclSH7eygKWPKWU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=A42/s2/bFtKZ/AeyCtaD8M9riPQcpeAsT9Vo43MfiHhG9F1WIggDSFAJtzJAhb3tw Kt4BoIupfmnqE+pDq0X3gliBgR0dXKNsjzgNQ0+tlHw7iS5oEdPvtcclnRGCGWN0/z PDCB0OGy/uIIJ2o5wLDopD4zn5t0Lj7vDyvcqDwaY9p1I2nfrgmFcPgBFOUr50Tjz2 w4j6hBfSEoSmi+Wjcl+uDsONz/6TmdHORS4hA6hbG74zd/ckVMwUIrk8a8WjHdtw98 s45DWSJPWyzYbiF8YGfAIrZcTHo2Rw6iEDbdtbQ8Y9YBFviXKver4LJunF9elKaCWc pa2Om15Jdy65g== From: Pratyush Yadav To: Markus Elfring Cc: Tao Liu , linux-riscv@lists.infradead.org, kexec@lists.infradead.org, linux-integrity@vger.kernel.org, Albert Ou , Alexandre Ghiti , Palmer Dabbelt , Paul Walmsley , kernel-janitors@vger.kernel.org, LKML , Baoquan He , Dmitry Kasatkin , Eric Snowberg , Jarkko Sakkinen , Mimi Zohar , Nutty Liu , Pratyush Yadav , Roberto Sassu Subject: Re: [PATCH v4] riscv: Prevent NULL pointer dereference in machine_kexec_prepare In-Reply-To: <5df82d42-89cd-4e39-95a9-a0f164c0ac58@web.de> (Markus Elfring's message of "Fri, 3 Jul 2026 16:38:09 +0200") References: <20260703111530.91285-2-ltao@redhat.com> <5df82d42-89cd-4e39-95a9-a0f164c0ac58@web.de> Date: Fri, 03 Jul 2026 16:59:48 +0200 Message-ID: <2vxzqzlkf7a3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jul 03 2026, Markus Elfring wrote: >> A NULL pointer dereference issue is noticed in riscv's machine_kexec_pre= pare(), >> where image->segment[i].buf might be NULL and copied unchecked. > =E2=80=A6 > > Would it be helpful to append parentheses to a function name also in the = summary phrase? > > Why was such a hint not be taken into account from a previous suggestion? Oh come on, this is a really really minor nitpick. The fact that machine_kexec_prepare is a function is fairly obvious when reading the patch. In fact, the first sentence of the commit message uses the parentheses. So yes, it would have been nice to have them in the subject. But no, this is not at all worth anyone's time to fix. Certainly not at all worth a v5. Please, let's not nitpick our contributors into giving up. --=20 Regards, Pratyush Yadav