From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9300235C1B6 for ; Mon, 11 May 2026 11:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778497525; cv=none; b=e0wCT4gfDRI7A2OF6hL1ufHisDYJkK4ktt9OrfH8Nqtg/Xyx6rcR8tO2sAldVxTjpVF/5q+77tPvPU/HYPuP7XD5rfrg0IsfC6qUsGTXlb0pWcMATjGPn9D+B7/yKrXE8Vd1YTnyvbMapTJUvSNnq6ulQZ7PYwdp8A7JleK0KTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778497525; c=relaxed/simple; bh=BztAq8w5VK1b2+D1NkvixBxhvrkj9m6ZLycQeOZt3oo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=geGCPXTrEoqsj2cI/MHUzVFaI8YAA1P3T9ryowNyUnggDNPQ7ylO3YR+j+BjSW6Fvm98hFGTUF+WRgnePlO3AmEhgAgWXW6lIC3wE+TbBP4yfmo2hvYLy2dN+JDCVVMzee9aocPNgYpLsS7BApmIFt6T0Lh0NlPhDnhu8tsZZmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AFb7kFFr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AFb7kFFr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15789C2BCB0; Mon, 11 May 2026 11:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778497525; bh=BztAq8w5VK1b2+D1NkvixBxhvrkj9m6ZLycQeOZt3oo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=AFb7kFFrakJ+O+jIq9DJ95cMQOTl61XQ/4sHtzYYZqyQCviZDiQzLDqgQt7e27XuY iC+uHAtm/SC2kbJmzJYRtHLEjiTxtZgqKN7wf7rNoS8P6cRmII+qOOe6ZsM+XQ9uTg A//Z5SCKYxT6VT8GnUl/0o5bKJOax0kxZEKZjVHn8W6q672EhOPi/KOCHWElpDSXHs Cg3LvoQ7KrKXB4aJKttls3nJL7CcRSWeo4qhPcQU9hC75d12Ph3VvqG+D3QwcEujum cCTvbypIMDtzDOO/tsg8TjldwDHZOF1M89vfkGRvYtL/RRZD+nqbraI2wrD889SpVK 4+AfaswtV6ZqQ== From: Pratyush Yadav To: Jork Loeser Cc: Pratyush Yadav , Mike Rapoport , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/12] kho: add kho_radix_init_tree() In-Reply-To: (Jork Loeser's message of "Wed, 6 May 2026 03:51:07 -0700 (PDT)") References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-9-pratyush@kernel.org> Date: Mon, 11 May 2026 13:05:21 +0200 Message-ID: <2vxzqzniciku.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, May 06 2026, Jork Loeser wrote: > On Wed, 29 Apr 2026, Pratyush Yadav wrote: > >> From: "Pratyush Yadav (Google)" >> >> Move the initialization logic of the radix tree into >> kho_radix_init_tree() instead of having users open-code it. Makes the >> boundaries cleaner and reduces code duplication when a new user of the >> radix tree will be added in a future commit. > > Consider using kho_radix_init_tree() in kho_init() as well. This will also > remove the kzalloc() one-off use. Similar for kho_radix_destroy_tree(). Good point. Will do. -- Regards, Pratyush Yadav