From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95A353E0231 for ; Thu, 2 Apr 2026 12:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775132243; cv=none; b=MUcm6zlFzw6xcLHVJV5Mh9L9kdrSn+6qcUqmsPzcNnmoRSSYgLUvGXSYJSHkr8FL6dZiN3viSkwVTgPOlUmu+jXSvJvmR8rptdcMMvn7k/4lRVaErJsRF3iA+gQCBtBC/l7ffeTFJCXwiR324EnVNbFPZC1kFzyxwuQAAxl0v3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775132243; c=relaxed/simple; bh=TY/B9W7yjGiDjnEemdIN9RGWi5wlXX80UphSEtYJ6+I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=s7tgsVCwfW2E06gtTUi/d5HKtN99zbuxvyVZ/ewA4rbdWF2Nw9zbUqyRTSVVM3BsT9MyS5W8tH4cYhS7IISYmrdb1ESM5yzYWk+wxzQXUoLM7rKlKPYxG6DZyyNL6dbt14wOGcfGwBbmkBukHAsaRuhxDmT99eejX6JuClCmoFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uU+DoKmV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uU+DoKmV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF123C116C6; Thu, 2 Apr 2026 12:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775132243; bh=TY/B9W7yjGiDjnEemdIN9RGWi5wlXX80UphSEtYJ6+I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=uU+DoKmVHHbBKl+x3wrfJeU22pRdv+bO3KGpx60e4NgmvklIy1W76t27mHyWmRTFL AHcYaXRavcXoQ1q19L/4dqo7WhdMb65NSXgPseXqaX7l+LVNfjwXa+jqnIPg7i9yXB qrPAHo8Z69PQY92wGIupFOOnGOd2vmUO0kuDqspMK8f5YhhCyVjMHwTMSvXzsgsjh6 Fm4qpK+U+1tKqkAKE57PeCOAL3cWxDIAMzdN5fBP4a17zNd52m4ClKpriZ/aT5Vu9B 1Cz4MibsJY4wUtemfNrueyhXXQBDaeb4E3ZXOEP2YsR9ud5TfPPhbKxpuFXMCkM/e+ g7XJeExu3pSfw== From: Pratyush Yadav To: Leo Timmins Cc: pasha.tatashin@soleen.com, rppt@kernel.org, linux-kernel@vger.kernel.org, pratyush@kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH v3 1/2] liveupdate: propagate file deserialization failures In-Reply-To: <20260326042546.8031-2-leotimmins1974@gmail.com> (Leo Timmins's message of "Thu, 26 Mar 2026 12:25:34 +0800") References: <20260326042546.8031-1-leotimmins1974@gmail.com> <20260326042546.8031-2-leotimmins1974@gmail.com> Date: Thu, 02 Apr 2026 12:17:20 +0000 Message-ID: <2vxzqzoxftf3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Mar 26 2026, Leo Timmins wrote: > luo_session_deserialize() ignored the return value from > luo_file_deserialize(). As a result, a session could be left partially > restored even though the /dev/liveupdate open path treats deserialization > failures as fatal. > > Propagate the error so a failed file deserialization aborts session > deserialization instead of silently continuing. > > Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preservation") > Reviewed-by: Pasha Tatashin > Signed-off-by: Leo Timmins Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav