From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF35A27FB1E for ; Tue, 10 Feb 2026 13:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770731129; cv=none; b=dFc8GzXEWDbqYvoTZpSFrTGEb5brUBKp6qE59LhhRXdOvhadNmZFw1aWLExAK3L40UHueB2uklE3lXw56+gTnjgxDvcE8k7szU6du27rLUWozKgG0vHwfPD2sfI7cZ29++Zmd0CvMFc4a5Ibs6IvQOkgEo8afH5eShHUelWUP9I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770731129; c=relaxed/simple; bh=UiB4cdtuv+0naMTeccJX5N93CPAw51/JaqNcoV4zvQ4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Cfy59rh/bgWYks2KwzUmPtZBftvt0mnqIRpuDtO1eig1nJAWxoV6IAsKWey0dcNSSN1GFG3+67EIe0WPUUlnT4tsKsK9U/2WSKosNDcw2tio0onjdc2kcueGV3CgCQ+Nqoq361N/8ZHgb0tITpUrFADxgCWSyg2aHAvpsaTxxCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c+FNjQ/k; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c+FNjQ/k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1B7AC116C6; Tue, 10 Feb 2026 13:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770731129; bh=UiB4cdtuv+0naMTeccJX5N93CPAw51/JaqNcoV4zvQ4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=c+FNjQ/k6DxcaBj3u8nCXsgF+qR8qI5/JZNA+al9t07HxZPquukG6/3JTaG/GdUf+ 0mpSuXjS9hPiec/0YhKAfDeVk/b0Lma8BW5FObxZDhilUcfn+HL4cPRoyIHawxFBYD 5JDUXg2sgnOnp9M4SzAHJWx8MwdmjJdssl0G5BCiWm/A2XpX1qlMJq7N8Smg4fpoZV OmNEdZyoweFmJDZKZfAn6lQq+TrSyJtDBmAOj9ES8YXBFoVH4Ed05ei01a4t6pMpN/ 6fJQO70fK45+mbWpwMjmEH6t6W6sxXY1NNT1yV7Hof71+nk5PISIS6zYVpBb7RP7Mm anRL+9IZrNLVA== From: Pratyush Yadav To: ranxiaokai627@163.com Cc: graf@amazon.com, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, akpm@linux-foundation.org, kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn Subject: Re: [PATCH -next 2/2] kho: remove unnecessary WARN_ON(err) in kho_populate() In-Reply-To: <20260206043121.197564-3-ranxiaokai627@163.com> (ranxiaokai's message of "Fri, 6 Feb 2026 04:31:21 +0000") References: <20260206043121.197564-1-ranxiaokai627@163.com> <20260206043121.197564-3-ranxiaokai627@163.com> Date: Tue, 10 Feb 2026 14:45:26 +0100 Message-ID: <2vxzqzqssoeh.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, Feb 06 2026, ranxiaokai627@163.com wrote: > From: Ran Xiaokai > > The following pr_warn() provides detailed error and location > information, WARN_ON(err) adds no additional debugging value, > so remove the redundant WARN_ON() call. > > Signed-off-by: Ran Xiaokai Reviewed-by: Pratyush Yadav [...] -- Regards, Pratyush Yadav