From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4508F307AC6 for ; Fri, 22 May 2026 15:02:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779462165; cv=none; b=RJUinMcWPos6Hcxmw6crcPt/taLdZGH+4I0CHCX6momN4PzG0PHULqKgRMLcSulpLQOIUjVwTWez9QbwQcKEcHxU7eV+J+6g5hAqBrI23hwprMZHFWTwu7iqprmiXnmzt35MAsYLM67xmhNzH+2a5wWLbVhrEtprC1mMoXKHTeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779462165; c=relaxed/simple; bh=7mJ1N1wg8jgPdvvtaO9t3Iy8HY4ud1qb6hsYtdvhnNY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=V6/PB38WStR+Uerr89V1YZdmaLHluAuH2Ndb9iMAhnmWaaNcxpllfHIRlHIDMLMpiJHZqh57kNX2nXkgGGgqjdvDQrsDYqPZ1jBlh/tK1hvkw3mg5k/HGMwt4swNzKu9TCEhkfYk9hQ481JTB/gyQViUrVMJgFwmZi7wej0TSHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KrfS+tJB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KrfS+tJB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E1C61F000E9; Fri, 22 May 2026 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779462162; bh=A2IrT8PydzK9xxtu2jbeHfoX/1GcdXru7uVPffwnQVk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=KrfS+tJBjhwvjCQc5lgSC6UFM6xUBTGfKJwHZGomUl3hmvnG1kj0ilOsmwLMOtvHs WkhRDeIH8FQct/ouklVCLMRrJcS4BKjeoi4U6HGiK3BZ7DhLP+gUuvdgdIKhpD1yeQ pKpFA76LjjW6sjKy3COwgf521ZIPorDv2JVVq+AP9nJYDkyGweg+5VRbvMyV65K+OV aMVCLwYyHtObaRLTb86V3MFbGhyycqmQnZ3xtdjEd0oeePDe/GK6oTq4Io2R0xvTOH DZcT6S+Tdy/0Ntak24i/r+mUMrhP0rIdIsr01sIslAsOIJMLNw/ikjSgkesOrd/DOv rfHbxnVUM2xoA== From: Pratyush Yadav To: Pasha Tatashin Cc: Pratyush Yadav , Mike Rapoport , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/12] memblock: introduce MEMBLOCK_KHO_SCRATCH_EXT In-Reply-To: (Pasha Tatashin's message of "Fri, 22 May 2026 00:48:35 +0000") References: <20260429133928.850721-1-pratyush@kernel.org> <20260429133928.850721-10-pratyush@kernel.org> <2vxzecjhc2s8.fsf@kernel.org> Date: Fri, 22 May 2026 17:02:38 +0200 Message-ID: <2vxzse7j7ai9.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Fri, May 22 2026, Pasha Tatashin wrote: > On 05-11 18:46, Pratyush Yadav wrote: >> On Mon, May 11 2026, Mike Rapoport wrote: >> >> > On Wed, Apr 29, 2026 at 03:39:11PM +0200, Pratyush Yadav wrote: >> >> From: "Pratyush Yadav (Google)" >> >> >> >> In the upcoming commits, the KHO will learn how to discover free blocks >> >> of memory by walking the KHO radix tree. It will then mark those regions >> >> as scratch to allow memory allocation in case scratch runs low. >> >> >> >> To differentiate the extended scratch areas from the main scratch areas, >> >> introduce MEMBLOCK_KHO_SCRATCH_EXT. Use it when choosing memblock flags >> >> for allocations during scratch-only. Teach should_skip_region() to check >> >> for both flags before deciding if the region should be skipped. >> > >> > Why there's a need to differentiate SCRATCH and SCRATCH_EXT? >> > SCRATCH (I still hate the name) means "memory memblock can safely use for > > +1000 > > I also strongly dislike this name and mentioned it in another thread > earlier today. > > If we ever decide to s/scratch/something-else/ globally, that should be a > separate cleanup effort. However, since we are introducing a brand new flag > here, we can discuss a better name for the _ext portion to avoid overloading > the "scratch" concept. > >> > the allocations". Initially this memory comes from the reservations in the >> > first kernel, but if the second kernel can find more memory to extend it, >> > why that additional memory should be treated differently? >> >> Two reasons: >> >> 1. We mark SCRATCH as MIGRATE_CMA. We don't want to do that for >> SCRATCH_EXT since this memory can be used for non-movable >> allocations. >> >> 2. Gigantic (1G) huge pages can not be allocated from scratch. They can >> be preserved memory and thus should not be allocated from SCRATCH. >> See patch 12 that does allocations for gigantic huge pages only from >> SCRATCH_EXT. >> >> I will add this in the commit message for the next version. >> >> Naming is hard, so if you have any better names I'm all ears :-) > > IMO, this scratch_ext is not "scratch" in the traditional KHO sense at all. > The traditional KHO scratch is what is passed from kernel to kernel and is > guaranteed to contain zero preserved memory. This new memory is not passed > from kernel to kernel and can contain preserved memory at runtime. It's > essentially just memory that we identify as currently unpreserved and release > early to the system. > > If we want to keep the naming aligned with the existing codebase for now: > MEMBLOCK_KHO_SCRATCH -> original scratch > MEMBLOCK_KHO_UNPRESERVED -> for the new memory (instead of SCRATCH_EXT) UNPRESERVED sounds good to me. I will use that for the next revision unless Mike objects. > > Alternatively, if we do want to tackle the global rename of "scratch" later: > MEMBLOCK_KHO_BOOTSTRAP -> for the original scratch > MEMBLOCK_KHO_UNPRESERVED -> for this new dynamic memory Or perhaps BOOTMEM? I suppose either of the two are somewhat better than scratch. Anyway, can we please do the SCRATCH rename as a separate series? I would like this series to not get muddled in the naming discussion. I will use UNPRESERVED for the new concept in v2 though. > > What do you think? > > Pasha -- Regards, Pratyush Yadav