Re: [PATCH] dell-laptop: use dedicated sysfs file for ALS

[Gabriele Mazzotta <gabriele.mzt@gmail.com>]

On Wednesday 21 January 2015 10:38:23 Darren Hart wrote:
> On Sun, Jan 18, 2015 at 07:34:17PM +0100, Gabriele Mazzotta wrote:
> > On Sunday 18 January 2015 10:08:21 Darren Hart wrote:
> > > On Wed, Jan 14, 2015 at 03:07:21PM +0100, Gabriele Mazzotta wrote:
> > > > Hi,
> > > > 
> > > > I decided to remove "als" from input_triggers and created a dedicated
> > > > sysfs file for it. Having it there was wrong and misleading.
> > > > I also updated the documentation to reflect this change and fixed the
> > > > wrong description of als_setting, now used for als_enabled.
> > > 
> > > Given this is a significant functional change, as opposed to a bug fix, I'm
> > > leaning toward reverting the original and adding back the corrected version to
> > > 3.20. I'm going to look at the total impact first - let me know if you have a
> > > strong argument one way or the other.
> > 
> > I'm not against this decision.
> > If you do, please remember to also revert the commit that added the
> > documentation.
> 
> Then for my pull request to Linus this week, I'll be reverting:
> 
> 02b2aaa platform: x86: dell-laptop: Add support for keyboard backlight
> 3161293 Documentation: Add entry for dell-laptop sysfs interface
> 
> Am I missing anything?

No, that's all.

Thanks,
Gabriele