AF_RXRPC depends on KEYS?

AF_RXRPC depends on KEYS?

[Geert Uytterhoeven]

| linux/net/rxrpc/af_rxrpc.c: In function 'rxrpc_kernel_begin_call':
| linux/net/rxrpc/af_rxrpc.c:303: error: dereferencing pointer to incomplete type
| linux/net/rxrpc/af_rxrpc.c: In function 'af_rxrpc_init':
| linux/net/rxrpc/af_rxrpc.c:820: warning: implicit declaration of function 'register_key_type'
| linux/net/rxrpc/af_rxrpc.c:839: warning: implicit declaration of function 'unregister_key_type'

Should AF_RXRPC depend on KEYS?

Hmm, I see a few more related things:

| linux/net/rxrpc/ar-key.c:36: error: variable 'key_type_rxrpc' has initializer but incomplete type
| linux/net/rxrpc/ar-key.c:37: error: unknown field 'name' specified in initializer
| linux/net/rxrpc/ar-key.c:37: warning: excess elements in struct initializer
| linux/net/rxrpc/ar-key.c:37: warning: (near initialization for 'key_type_rxrpc')
| linux/net/rxrpc/ar-key.c:38: error: unknown field 'instantiate' specified in initializer
| ...

and

| linux/net/rxrpc/ar-output.c: In function 'rxrpc_client_sendmsg':
| linux/net/rxrpc/ar-output.c:158: error: dereferencing pointer to incomplete type

and

| linux/net/rxrpc/ar-security.c: In function 'rxrpc_init_client_conn_security':
| linux/net/rxrpc/ar-security.c:138: error: dereferencing pointer to incomplete type/home/geert.nba/linux/linux-m68k-2.6.22-rc1/net/rxrpc/ar-security.c: In function 'rxrpc_init_server_conn_security':
| linux/net/rxrpc/ar-security.c:163: error: 'key_ref_t' undeclared (first use in this function)
| ...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: AF_RXRPC depends on KEYS?

[David Howells]

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Should AF_RXRPC depend on KEYS?

Ummm... yes it probably should.  It's just that I normally build rxkad too,
and that does depend on keys.

David