From: David Howells <dhowells@redhat.com>
To: Greg Ungerer <gerg@snapgear.com>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: BUG: failure at mm/nommu.c:518/add_nommu_region()
Date: Wed, 06 May 2009 15:11:19 +0100 [thread overview]
Message-ID: <30031.1241619079@redhat.com> (raw)
In-Reply-To: <4A00EF23.4050302@snapgear.com>
Can you try the attached patch, please?
David
---
From: David Howells <dhowells@redhat.com>
Subject: [PATCH] NOMMU: Don't check vm_region::vm_start is page aligned in add_nommu_region()
Don't check vm_region::vm_start is page aligned in add_nommu_region() because
the region may reflect some non-page-aligned mapped file, such as could be
obtained from RomFS XIP.
Signed-off-by: David Howells <dhowells@redhat.com>
---
mm/nommu.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/nommu.c b/mm/nommu.c
index cdc6f60..325706b 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -515,8 +515,6 @@ static void add_nommu_region(struct vm_region *region)
validate_nommu_regions();
- BUG_ON(region->vm_start & ~PAGE_MASK);
-
parent = NULL;
p = &nommu_region_tree.rb_node;
while (*p) {
next prev parent reply other threads:[~2009-05-06 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-05 1:30 BUG: failure at mm/nommu.c:518/add_nommu_region() Greg Ungerer
2009-05-05 13:41 ` David Howells
2009-05-06 2:00 ` Greg Ungerer
2009-05-06 11:21 ` David Howells
2009-05-06 14:11 ` David Howells [this message]
2009-05-07 0:13 ` Greg Ungerer
2009-05-07 8:38 ` David Howells
2009-05-07 8:45 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30031.1241619079@redhat.com \
--to=dhowells@redhat.com \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox