public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org,
	Richard Henderson <rth@twiddle.net>,
	Russell King <rmk@arm.linux.org.uk>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>,
	Bryan Wu <cooloney@kernel.org>, Mikael Starvik <starvik@axis.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Tony Luck <tony.luck@intel.com>,
	Hirokazu Takata <takata@linux-m32r.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@uclinux.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Grant Grundler <grundler@parisc-linux.org>,
	Paul Mackerras <paulus@samba.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Paul Mundt <lethal@linux-sh.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jeff Dike <jdike@addtoit.com>, Ingo Molnar <mingo@redhat.com>,
	Chris Zankel <chris@zankel.net>
Subject: Re: [RFC 5/8] param: arch_get_boot_command_line() (take II)
Date: Wed, 03 Dec 2008 13:18:57 +0000	[thread overview]
Message-ID: <30032.1228310337@redhat.com> (raw)
In-Reply-To: <200812031350.46794.rusty@rustcorp.com.au>

Rusty Russell <rusty@rustcorp.com.au> wrote:

> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -115,7 +115,6 @@ static struct meminfo meminfo __initdata
>  static struct meminfo meminfo __initdata = { 0, };
>  static const char *cpu_name;
>  static const char *machine_name;
> -static char __initdata command_line[COMMAND_LINE_SIZE];
>  
>  static char default_command_line[COMMAND_LINE_SIZE] __initdata = CONFIG_CMDLINE;
>  static union { char c[4]; unsigned long l; } endian_test __initdata = { { 'l', '?', '?', 'b' 
> } };
> @@ -414,10 +413,12 @@ __early_param("mem=", early_mem);

Your patch is broken here:

	missing header for unified diff at line 140 of patch
	can't find file to patch at input line 140
	Perhaps you used the wrong -p or --strip option?
	The text leading up to this was:
	--------------------------
	|} };
	--------------------------
	File to patch: ^C

Has your email client wrapped a line?

David

  reply	other threads:[~2008-12-03 13:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01 12:56 [RFC 5/8] param: arch_get_boot_command_line() Rusty Russell
2008-12-01 13:18 ` Russell King
2008-12-02  2:13   ` Rusty Russell
2008-12-02  9:23     ` Haavard Skinnemoen
2008-12-03  2:30       ` Rusty Russell
2008-12-02 17:44     ` Russell King
2008-12-03  0:41       ` Rusty Russell
2008-12-03  0:54 ` Greg Ungerer
2008-12-03  2:38   ` Rusty Russell
2008-12-03  3:20 ` [RFC 5/8] param: arch_get_boot_command_line() (take II) Rusty Russell
2008-12-03 13:18   ` David Howells [this message]
2008-12-03 22:32     ` Rusty Russell
2008-12-03 18:37   ` Luck, Tony
2008-12-03 18:37     ` Luck, Tony
2008-12-04  0:58       ` Rusty Russell
2008-12-06 20:42         ` Russell King
2008-12-07  8:44           ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30032.1228310337@redhat.com \
    --to=dhowells@redhat.com \
    --cc=chris@zankel.net \
    --cc=cooloney@kernel.org \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=grundler@parisc-linux.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hskinnemoen@atmel.com \
    --cc=jdike@addtoit.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=rth@twiddle.net \
    --cc=rusty@rustcorp.com.au \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox