public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: dhowells@redhat.com,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"raven@themaw.net" <raven@themaw.net>,
	"kzak@redhat.com" <kzak@redhat.com>,
	"jarkko.sakkinen@linux.intel.com"
	<jarkko.sakkinen@linux.intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"dray@redhat.com" <dray@redhat.com>,
	"swhiteho@redhat.com" <swhiteho@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"mszeredi@redhat.com" <mszeredi@redhat.com>,
	"jlayton@redhat.com" <jlayton@redhat.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"andres@anarazel.de" <andres@anarazel.de>,
	"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
	"christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>
Subject: Re: [GIT PULL] General notification queue and key notifications
Date: Wed, 24 Jun 2020 01:55:16 +0100	[thread overview]
Message-ID: <3015561.1592960116@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAPcyv4g+T+GK4yVJs8bTT1q90SFDpFYUSL9Pk_u8WZROhREPkw@mail.gmail.com>

Dan Williams <dan.j.williams@intel.com> wrote:

> > This commit:
> >
> > >       keys: Make the KEY_NEED_* perms an enum rather than a mask
> >
> > ...upstream as:
> >
> >     8c0637e950d6 keys: Make the KEY_NEED_* perms an enum rather than a mask
> >
> > ...triggers a regression in the libnvdimm unit test that exercises the
> > encrypted keys used to store nvdimm passphrases. It results in the
> > below warning.
> 
> This regression is still present in tip of tree. David, have you had a
> chance to take a look?

nvdimm_lookup_user_key() needs to indicate to lookup_user_key() what it wants
the key for so that the appropriate security checks can take place in SELinux
and Smack.  Note that I have a patch in the works that changes this still
further.

Does setting the third argument of lookup_user_key() to KEY_NEED_SEARCH work
for you?

David


  reply	other threads:[~2020-06-24  0:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02 15:55 [GIT PULL] General notification queue and key notifications David Howells
2020-06-03  2:15 ` Ian Kent
2020-06-08  0:49   ` Ian Kent
2020-06-10  9:56 ` Christian Brauner
2020-06-10 11:12 ` Karel Zak
2020-06-12 21:32   ` Linus Torvalds
2020-06-13 13:04     ` David Howells
2020-06-13 16:47       ` Linus Torvalds
2020-06-13 17:03         ` Linus Torvalds
2020-06-13 19:22       ` Miklos Szeredi
2020-06-12 22:01   ` Linus Torvalds
2020-06-13 13:24     ` David Howells
2020-06-13 18:00 ` pr-tracker-bot
2020-06-17  1:15 ` Williams, Dan J
2020-06-23 23:38   ` Dan Williams
2020-06-24  0:55     ` David Howells [this message]
2020-06-24  1:03       ` Dan Williams
2020-06-24  1:17         ` David Howells
  -- strict thread matches above, loose matches on Subject: below --
2020-06-02 15:51 David Howells
2020-06-02 15:54 ` David Howells
2020-03-30 13:58 Upcoming: Notifications, FS notifications and fsinfo() David Howells
2020-03-30 14:31 ` [GIT PULL] General notification queue and key notifications David Howells
2020-03-31  6:51   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3015561.1592960116@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=andres@anarazel.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=dan.j.williams@intel.com \
    --cc=dray@redhat.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jlayton@redhat.com \
    --cc=keyrings@vger.kernel.org \
    --cc=kzak@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mszeredi@redhat.com \
    --cc=raven@themaw.net \
    --cc=swhiteho@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox