* [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
@ 2023-07-14 15:31 Alejandro Tafalla
2023-07-15 17:35 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Tafalla @ 2023-07-14 15:31 UTC (permalink / raw)
To: Lorenzo Bianconi, Jonathan Cameron, Lars-Peter Clausen
Cc: Alejandro Tafalla, Jonathan Cameron, linux-iio, linux-kernel
The function lsm6dsx_get_acpi_mount_matrix should return an error when ACPI
support is not enabled to allow executing iio_read_mount_matrix in the
probe function.
Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
---
Changes in v3:
- Removed unneeded check for err == -EOPNOTSUPP.
Changes in v2:
- Use of error codes instead of true/false
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index 6a18b363cf73..b6e6b1df8a61 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
struct iio_mount_matrix *orientation)
{
- return false;
+ return -EOPNOTSUPP;
}
#endif
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
2023-07-14 15:31 [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval Alejandro Tafalla
@ 2023-07-15 17:35 ` Jonathan Cameron
2023-07-17 21:17 ` Alejandro Tafalla
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2023-07-15 17:35 UTC (permalink / raw)
To: Alejandro Tafalla
Cc: Lorenzo Bianconi, Lars-Peter Clausen, Jonathan Cameron, linux-iio,
linux-kernel
On Fri, 14 Jul 2023 17:31:26 +0200
Alejandro Tafalla <atafalla@dnyon.com> wrote:
> The function lsm6dsx_get_acpi_mount_matrix should return an error when ACPI
> support is not enabled to allow executing iio_read_mount_matrix in the
> probe function.
>
> Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
>
I can fix it up whilst applying if no other issues, but there must not be
a blank line here. All tags need to be in a single block for some tooling
that is used with the kernel tree (and some of the checking scripts warn
about this so it won't get applied with the blank line here).
> Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> ---
> Changes in v3:
> - Removed unneeded check for err == -EOPNOTSUPP.
>
> Changes in v2:
> - Use of error codes instead of true/false
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 6a18b363cf73..b6e6b1df8a61 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> struct iio_mount_matrix *orientation)
> {
> - return false;
> + return -EOPNOTSUPP;
> }
>
> #endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
2023-07-15 17:35 ` Jonathan Cameron
@ 2023-07-17 21:17 ` Alejandro Tafalla
2023-07-20 18:40 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Tafalla @ 2023-07-17 21:17 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Lorenzo Bianconi, Lars-Peter Clausen, Jonathan Cameron, linux-iio,
linux-kernel
On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> On Fri, 14 Jul 2023 17:31:26 +0200
>
> Alejandro Tafalla <atafalla@dnyon.com> wrote:
> > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > ACPI
> > support is not enabled to allow executing iio_read_mount_matrix in the
> > probe function.
> >
> > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
>
> I can fix it up whilst applying if no other issues, but there must not be
> a blank line here. All tags need to be in a single block for some tooling
> that is used with the kernel tree (and some of the checking scripts warn
> about this so it won't get applied with the blank line here).
Okay, i'll keep it in mind for new patches. Thank you.
>
> > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > ---
> > Changes in v3:
> > - Removed unneeded check for err == -EOPNOTSUPP.
> >
> > Changes in v2:
> > - Use of error codes instead of true/false
> >
> > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > 6a18b363cf73..b6e6b1df8a61 100644
> > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > device *dev,>
> > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> >
> > struct
iio_mount_matrix *orientation)
> >
> > {
> >
> > - return false;
> > + return -EOPNOTSUPP;
> >
> > }
> >
> > #endif
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
2023-07-17 21:17 ` Alejandro Tafalla
@ 2023-07-20 18:40 ` Jonathan Cameron
2023-07-20 21:27 ` Lorenzo Bianconi
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2023-07-20 18:40 UTC (permalink / raw)
To: Alejandro Tafalla
Cc: Lorenzo Bianconi, Lars-Peter Clausen, Jonathan Cameron, linux-iio,
linux-kernel
On Mon, 17 Jul 2023 23:17:10 +0200
Alejandro Tafalla <atafalla@dnyon.com> wrote:
> On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> > On Fri, 14 Jul 2023 17:31:26 +0200
> >
> > Alejandro Tafalla <atafalla@dnyon.com> wrote:
> > > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > > ACPI
> > > support is not enabled to allow executing iio_read_mount_matrix in the
> > > probe function.
> > >
> > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> >
> > I can fix it up whilst applying if no other issues, but there must not be
> > a blank line here. All tags need to be in a single block for some tooling
> > that is used with the kernel tree (and some of the checking scripts warn
> > about this so it won't get applied with the blank line here).
>
> Okay, i'll keep it in mind for new patches. Thank you.
Np.
Just waiting for Lorenzo to have time to take a final look.
Jonathan
> >
> > > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > > ---
> > > Changes in v3:
> > > - Removed unneeded check for err == -EOPNOTSUPP.
> > >
> > > Changes in v2:
> > > - Use of error codes instead of true/false
> > >
> > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > > 6a18b363cf73..b6e6b1df8a61 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > > device *dev,>
> > > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > >
> > > struct
> iio_mount_matrix *orientation)
> > >
> > > {
> > >
> > > - return false;
> > > + return -EOPNOTSUPP;
> > >
> > > }
> > >
> > > #endif
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
2023-07-20 18:40 ` Jonathan Cameron
@ 2023-07-20 21:27 ` Lorenzo Bianconi
2023-07-23 12:50 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2023-07-20 21:27 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Alejandro Tafalla, Lars-Peter Clausen, Jonathan Cameron,
linux-iio, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2231 bytes --]
On Jul 20, Jonathan Cameron wrote:
> Alejandro Tafalla <atafalla@dnyon.com> wrote:
>
> > On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> > > On Fri, 14 Jul 2023 17:31:26 +0200
> > >
> > > Alejandro Tafalla <atafalla@dnyon.com> wrote:
> > > > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > > > ACPI
> > > > support is not enabled to allow executing iio_read_mount_matrix in the
> > > > probe function.
> > > >
> > > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> > >
> > > I can fix it up whilst applying if no other issues, but there must not be
> > > a blank line here. All tags need to be in a single block for some tooling
> > > that is used with the kernel tree (and some of the checking scripts warn
> > > about this so it won't get applied with the blank line here).
> >
> > Okay, i'll keep it in mind for new patches. Thank you.
> Np.
>
> Just waiting for Lorenzo to have time to take a final look.
I am fine with this patch.
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> Jonathan
>
> > >
> > > > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > > > ---
> > > > Changes in v3:
> > > > - Removed unneeded check for err == -EOPNOTSUPP.
> > > >
> > > > Changes in v2:
> > > > - Use of error codes instead of true/false
> > > >
> > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > > > 6a18b363cf73..b6e6b1df8a61 100644
> > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > > > device *dev,>
> > > > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > > >
> > > > struct
> > iio_mount_matrix *orientation)
> > > >
> > > > {
> > > >
> > > > - return false;
> > > > + return -EOPNOTSUPP;
> > > >
> > > > }
> > > >
> > > > #endif
> >
> >
> >
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval
2023-07-20 21:27 ` Lorenzo Bianconi
@ 2023-07-23 12:50 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2023-07-23 12:50 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Alejandro Tafalla, Lars-Peter Clausen, Jonathan Cameron,
linux-iio, linux-kernel
On Thu, 20 Jul 2023 23:27:53 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> On Jul 20, Jonathan Cameron wrote:
> > Alejandro Tafalla <atafalla@dnyon.com> wrote:
> >
> > > On sábado, 15 de julio de 2023 19:35:15 (CEST) Jonathan Cameron wrote:
> > > > On Fri, 14 Jul 2023 17:31:26 +0200
> > > >
> > > > Alejandro Tafalla <atafalla@dnyon.com> wrote:
> > > > > The function lsm6dsx_get_acpi_mount_matrix should return an error when
> > > > > ACPI
> > > > > support is not enabled to allow executing iio_read_mount_matrix in the
> > > > > probe function.
> > > > >
> > > > > Fixes: dc3d25f22b88 ("iio: imu: lsm6dsx: Add ACPI mount matrix retrieval")
> > > >
> > > > I can fix it up whilst applying if no other issues, but there must not be
> > > > a blank line here. All tags need to be in a single block for some tooling
> > > > that is used with the kernel tree (and some of the checking scripts warn
> > > > about this so it won't get applied with the blank line here).
> > >
> > > Okay, i'll keep it in mind for new patches. Thank you.
> > Np.
> >
> > Just waiting for Lorenzo to have time to take a final look.
>
> I am fine with this patch.
>
> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
Ah. My filters broke so I'd lost this. Thankfully b4 picked it up and made
me go look for where the missing emails had gone. All recovered now
and the ack picked up.
Thanks,
Jonathan
> >
> > Jonathan
> >
> > > >
> > > > > Signed-off-by: Alejandro Tafalla <atafalla@dnyon.com>
> > > > > ---
> > > > > Changes in v3:
> > > > > - Removed unneeded check for err == -EOPNOTSUPP.
> > > > >
> > > > > Changes in v2:
> > > > > - Use of error codes instead of true/false
> > > > >
> > > > > drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c index
> > > > > 6a18b363cf73..b6e6b1df8a61 100644
> > > > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > > > @@ -2687,7 +2687,7 @@ static int lsm6dsx_get_acpi_mount_matrix(struct
> > > > > device *dev,>
> > > > > static int lsm6dsx_get_acpi_mount_matrix(struct device *dev,
> > > > >
> > > > > struct
> > > iio_mount_matrix *orientation)
> > > > >
> > > > > {
> > > > >
> > > > > - return false;
> > > > > + return -EOPNOTSUPP;
> > > > >
> > > > > }
> > > > >
> > > > > #endif
> > >
> > >
> > >
> > >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-23 12:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 15:31 [PATCH v3] iio: imu: lsm6dsx: Fix mount matrix retrieval Alejandro Tafalla
2023-07-15 17:35 ` Jonathan Cameron
2023-07-17 21:17 ` Alejandro Tafalla
2023-07-20 18:40 ` Jonathan Cameron
2023-07-20 21:27 ` Lorenzo Bianconi
2023-07-23 12:50 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox