From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbdJDOef (ORCPT ); Wed, 4 Oct 2017 10:34:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9341 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbdJDOec (ORCPT ); Wed, 4 Oct 2017 10:34:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B7A777EAAB Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dhowells@redhat.com Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170927195047.122358-2-ebiggers3@gmail.com> References: <20170927195047.122358-2-ebiggers3@gmail.com> <20170927195047.122358-1-ebiggers3@gmail.com> To: Eric Biggers Cc: dhowells@redhat.com, keyrings@vger.kernel.org, Michael Halcrow , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , stable@vger.kernel.org Subject: Re: [PATCH v3 1/7] KEYS: don't let add_key() update an uninstantiated key MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3018.1507127670.1@warthog.procyon.org.uk> Date: Wed, 04 Oct 2017 15:34:30 +0100 Message-ID: <3019.1507127670@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 04 Oct 2017 14:34:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric Biggers wrote: > + if ((key->flags & ((1 << KEY_FLAG_INVALIDATED) | > + (1 << KEY_FLAG_REVOKED) | > + (1 << KEY_FLAG_INSTANTIATED))) != > + (1 << KEY_FLAG_INSTANTIATED)) { Does this need READ_ONCE(), I wonder? David