[PATCH 0/4] ARM: multi_v7_defconfig: Improve rockchip support

[PATCH 0/4] ARM: multi_v7_defconfig: Improve rockchip support

[Sjoerd Simons]

Enable options to provide more complete support for Rockchip boards
including: support for the common act8846 PMIC, I2C, SPI, PMW, Thermal
driver, HDMI video output and USB 2.


Sjoerd Simons (4):
  ARM: multi_v7_defconfig: Enable common Rockchip devices/busses
  ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver
  ARM: multi_v7_defconfig: Enable Rockchip display support
  ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

 arch/arm/configs/multi_v7_defconfig | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
2.5.1

[PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Sjoerd Simons]

Enable Rockchip I2C, SPI, PWM, thermal drivers.

Builtin are:
 * I2C as it often controls the pmic.
 * Thermal, prevent thermal damage.

SPI and PWM configured as modules

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 36aa6e3..25a1d574 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -302,6 +302,7 @@ CONFIG_I2C_GPIO=m
 CONFIG_I2C_EXYNOS5=y
 CONFIG_I2C_MV64XXX=y
 CONFIG_I2C_RIIC=y
+CONFIG_I2C_RK3X=y
 CONFIG_I2C_S3C2410=y
 CONFIG_I2C_SH_MOBILE=y
 CONFIG_I2C_SIRF=y
@@ -318,6 +319,7 @@ CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_OMAP24XX=y
 CONFIG_SPI_ORION=y
 CONFIG_SPI_PL022=y
+CONFIG_SPI_ROCKCHIP=m
 CONFIG_SPI_RSPI=y
 CONFIG_SPI_S3C64XX=m
 CONFIG_SPI_SH_MSIOF=m
@@ -365,6 +367,7 @@ CONFIG_SENSORS_LM95245=y
 CONFIG_SENSORS_NTC_THERMISTOR=m
 CONFIG_THERMAL=y
 CONFIG_CPU_THERMAL=y
+CONFIG_ROCKCHIP_THERMAL=y
 CONFIG_RCAR_THERMAL=y
 CONFIG_ARMADA_THERMAL=y
 CONFIG_DAVINCI_WATCHDOG=m
@@ -642,6 +645,7 @@ CONFIG_PWM=y
 CONFIG_PWM_ATMEL=m
 CONFIG_PWM_ATMEL_TCB=m
 CONFIG_PWM_RENESAS_TPU=y
+CONFIG_PWM_ROCKCHIP=m
 CONFIG_PWM_SAMSUNG=m
 CONFIG_PWM_SUN4I=y
 CONFIG_PWM_TEGRA=y
-- 
2.5.1

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Javier Martinez Canillas]

Hello Sjoerd,

On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Enable Rockchip I2C, SPI, PWM, thermal drivers.
> 
> Builtin are:
>  * I2C as it often controls the pmic.

Having I2C as a module will cause more probe deferrals due missing
regulators and slow down the boot but it should not cause issues.
Or am I missing something?

In fact, I think even the PMIC could be built as a module.

But I don't have a strong opinion on this so patch looks good:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Sjoerd Simons]

On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> > Enable Rockchip I2C, SPI, PWM, thermal drivers.
> > 
> > Builtin are:
> >  * I2C as it often controls the pmic.
> 
> Having I2C as a module will cause more probe deferrals due missing
> regulators and slow down the boot but it should not cause issues.
> Or am I missing something?
> 
> In fact, I think even the PMIC could be built as a module.

It could in principle. However as a lot of other drivers do need the
regulators provided by the pmic, they'll be deferred until that driver
is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
boot to an NFS rootfs without using an initramfs. 

> But I don't have a strong opinion on this so patch looks good:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Javier Martinez Canillas]

Hello Sjoerd,

On 09/07/2015 12:24 PM, Sjoerd Simons wrote:
> On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
>> Hello Sjoerd,
>>
>> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
>>> Enable Rockchip I2C, SPI, PWM, thermal drivers.
>>>
>>> Builtin are:
>>>  * I2C as it often controls the pmic.
>>
>> Having I2C as a module will cause more probe deferrals due missing
>> regulators and slow down the boot but it should not cause issues.
>> Or am I missing something?
>>
>> In fact, I think even the PMIC could be built as a module.
> 
> It could in principle. However as a lot of other drivers do need the
> regulators provided by the pmic, they'll be deferred until that driver
> is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
> boot to an NFS rootfs without using an initramfs. 
>

Right, not needing an initramfs is certainly a good reason. If you could
add something like that in the commit message of patches 1/4 and 2/4 that
would be great.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 2578 bytes --]

On Mon, Sep 07, 2015 at 12:38:08PM +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On 09/07/2015 12:24 PM, Sjoerd Simons wrote:
> > On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
> >> Hello Sjoerd,
> >>
> >> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> >>> Enable Rockchip I2C, SPI, PWM, thermal drivers.
> >>>
> >>> Builtin are:
> >>>  * I2C as it often controls the pmic.
> >>
> >> Having I2C as a module will cause more probe deferrals due missing
> >> regulators and slow down the boot but it should not cause issues.
> >> Or am I missing something?
> >>
> >> In fact, I think even the PMIC could be built as a module.
> > 
> > It could in principle. However as a lot of other drivers do need the
> > regulators provided by the pmic, they'll be deferred until that driver
> > is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
> > boot to an NFS rootfs without using an initramfs. 
> >
> 
> Right, not needing an initramfs is certainly a good reason. If you could
> add something like that in the commit message of patches 1/4 and 2/4 that
> would be great.

I don't know. multi_v7_defconfig is primarily useful as a means to
quickly get a configuration that has most drivers enabled that most ARM
SoCs need. As such it's more of a convenience for build testing rather
than using it for booting a device.

I don't think the focus should be on optimizing for boot speed. Rather
if you do want to optimize for a device going through the trouble of
setting up an initial ramdisk isn't all that complicated. Even more so
because if you build drivers into the kernel and those drivers happen
to require firmware then people will be required to setup initial
ramdisks anyway.

Building too many drivers into the kernel has in the past often lead to
problems where all of a sudden the kernel became too big to fit into any
reasonably sized region of memory and cause all sorts of weird failures
in boot farms. Building everything as modules has the advantage that the
size of the zImage itself doesn't vary much, hence has less of a chance
to break boot farms.

There are quite a few drivers in multi_v7_defconfig that I suspect could
be built as loadable modules to decrease the size of the images that are
currently generated.

I understand that not everybody likes the additional ramdisk but, in my
opinion, that's what SoC-specific default configurations are good for.
We can use those to provide a base for developers where the focus is
ease of testability.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Andy Yan]

Hi
     There are also many other devices like display and mmc and even
the cpu(if the cpu want run a high frequency when boot up)need to
get power supply from PMIC, so it is better to load PMIC as early as
possible.Built-in is a better choice.

On 2015年09月07日 18:24, Sjoerd Simons wrote:
> On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
>> Hello Sjoerd,
>>
>> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
>>> Enable Rockchip I2C, SPI, PWM, thermal drivers.
>>>
>>> Builtin are:
>>>   * I2C as it often controls the pmic.
>> Having I2C as a module will cause more probe deferrals due missing
>> regulators and slow down the boot but it should not cause issues.
>> Or am I missing something?
>>
>> In fact, I think even the PMIC could be built as a module.
> It could in principle. However as a lot of other drivers do need the
> regulators provided by the pmic, they'll be deferred until that driver
> is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
> boot to an NFS rootfs without using an initramfs.
>
>> But I don't have a strong opinion on this so patch looks good:
>>
>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> Best regards,

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

[Javier Martinez Canillas]

Hello Andy,

On 09/07/2015 12:55 PM, Andy Yan wrote:
> Hi
>     There are also many other devices like display and mmc and even
> the cpu(if the cpu want run a high frequency when boot up)need to
> get power supply from PMIC, so it is better to load PMIC as early as
> possible.Built-in is a better choice.
>

Please don't top post, it makes following the conversation much harder.

Yes, I know that many devices needs the regulators provided by the PMIC
but that it's also true for all the regulators in all the PMICs for all
the boards supported by multi_v7_defconfig.

So to keep the kernel binary on a reasonable size, the current multi_v7
policy is to enable as much as possible as a module so just saying that
many other devices are using regulators from this PMIC is not enough.

Saying that it will allow mounting a NFS rootfs without an initramfs as
Sjoerd said is a much better justification IMHO.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver

[Sjoerd Simons]

Active Semi act8846 is used as the PMIC on various Rockchip boards,
enable the ACT8865 driver to support this.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---

 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 25a1d574..7058fef 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR_AB8500=y
+CONFIG_REGULATOR_ACT8865=y
 CONFIG_REGULATOR_AS3711=y
 CONFIG_REGULATOR_AS3722=y
 CONFIG_REGULATOR_AXP20X=y
-- 
2.5.1

Re: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver

[Javier Martinez Canillas]

Hello Sjoerd,

On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Active Semi act8846 is used as the PMIC on various Rockchip boards,
> enable the ACT8865 driver to support this.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 25a1d574..7058fef 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
>  CONFIG_MFD_TPS6586X=y
>  CONFIG_MFD_TPS65910=y
>  CONFIG_REGULATOR_AB8500=y
> +CONFIG_REGULATOR_ACT8865=y

Same question than the previous patch, does this really need to be
built-in? The Kconfig symbol is tristate.

After an explanation why it needs to be built-in or enabling
it as a module:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver

[Heiko Stübner]

Hi,

I guess one could rename that to something like
"ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards"

and as well add

CONFIG_REGULATOR_FAN53555=y
CONFIG_MFD_RK808=y
CONFIG_REGULATOR_RK808=y

fan5355 is the driver providing support for the syr82x used on all rk3288 
boards with an act8846.



Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons:
> Active Semi act8846 is used as the PMIC on various Rockchip boards,
> enable the ACT8865 driver to support this.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>


> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
>  CONFIG_MFD_TPS6586X=y
>  CONFIG_MFD_TPS65910=y
>  CONFIG_REGULATOR_AB8500=y
> +CONFIG_REGULATOR_ACT8865=y
>  CONFIG_REGULATOR_AS3711=y
>  CONFIG_REGULATOR_AS3722=y
>  CONFIG_REGULATOR_AXP20X=y

Re: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver

[Andy Yan]

PMIC RK808 used on many rk3288 boards ,such as Popmetal.
It is a MFD with function regulator and RTC. So if you plan to enable
RK808, please also enable CONFIG_RTC_DRV_RK808.

thanks.

On 2015年09月07日 17:33, Heiko Stübner wrote:
> Hi,
>
> I guess one could rename that to something like
> "ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards"
>
> and as well add
>
> CONFIG_REGULATOR_FAN53555=y
> CONFIG_MFD_RK808=y
> CONFIG_REGULATOR_RK808=y
>
> fan5355 is the driver providing support for the syr82x used on all rk3288
> boards with an act8846.
>
>
>
> Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons:
>> Active Semi act8846 is used as the PMIC on various Rockchip boards,
>> enable the ACT8865 driver to support this.
>>
>> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
>> ---
>>
>>   arch/arm/configs/multi_v7_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig
>> b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
>>   CONFIG_MFD_TPS6586X=y
>>   CONFIG_MFD_TPS65910=y
>>   CONFIG_REGULATOR_AB8500=y
>> +CONFIG_REGULATOR_ACT8865=y
>>   CONFIG_REGULATOR_AS3711=y
>>   CONFIG_REGULATOR_AS3722=y
>>   CONFIG_REGULATOR_AXP20X=y
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>

Re: [PATCH 2/4] ARM: multi_v7_defconfig: Enable ACT8865 PMIC driver

[Heiko Stübner]

Hi Andy,

Am Montag, 7. September 2015, 18:49:02 schrieb Andy Yan:
> PMIC RK808 used on many rk3288 boards ,such as Popmetal.
> It is a MFD with function regulator and RTC. So if you plan to enable
> RK808, please also enable CONFIG_RTC_DRV_RK808.

I think that could go into a separate patch5 ... enabling
	CONFIG_RTC_DRV_RK808=m
	CONFIG_RTC_DRV_HYM8563=m

the two rtc types used on all(?) Rockchip boards. So enable the rk808 
mfd+regulator here and do the rtcs separately later.


> On 2015年09月07日 17:33, Heiko Stübner wrote:
> > Hi,
> > 
> > I guess one could rename that to something like
> > "ARM: multi_v7_defconfig: Enable regulators used on most rockchip boards"
> > 
> > and as well add
> > 
> > CONFIG_REGULATOR_FAN53555=y
> > CONFIG_MFD_RK808=y
> > CONFIG_REGULATOR_RK808=y
> > 
> > fan5355 is the driver providing support for the syr82x used on all rk3288
> > boards with an act8846.
> > 
> > Am Sonntag, 6. September 2015, 22:16:04 schrieb Sjoerd Simons:
> >> Active Semi act8846 is used as the PMIC on various Rockchip boards,
> >> enable the ACT8865 driver to support this.
> >> 
> >> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> >> 
> >> ---
> >> 
> >>   arch/arm/configs/multi_v7_defconfig | 1 +
> >>   1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/arch/arm/configs/multi_v7_defconfig
> >> b/arch/arm/configs/multi_v7_defconfig index 25a1d574..7058fef 100644
> >> --- a/arch/arm/configs/multi_v7_defconfig
> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >> @@ -401,6 +401,7 @@ CONFIG_MFD_TPS65090=y
> >> 
> >>   CONFIG_MFD_TPS6586X=y
> >>   CONFIG_MFD_TPS65910=y
> >>   CONFIG_REGULATOR_AB8500=y
> >> 
> >> +CONFIG_REGULATOR_ACT8865=y
> >> 
> >>   CONFIG_REGULATOR_AS3711=y
> >>   CONFIG_REGULATOR_AS3722=y
> >>   CONFIG_REGULATOR_AXP20X=y
> > 
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 3/4] ARM: multi_v7_defconfig: Enable Rockchip display support

[Sjoerd Simons]

Enable options needed for HDMI out on rockchip: DRM driver, Rockchip
DesignWare HDMI glue and the rockchip IOMMU (dependency of the DRM
driver).

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---

 arch/arm/configs/multi_v7_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7058fef..fb673e2 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -453,6 +453,8 @@ CONFIG_DRM_EXYNOS=m
 CONFIG_DRM_EXYNOS_DSI=y
 CONFIG_DRM_EXYNOS_FIMD=y
 CONFIG_DRM_EXYNOS_HDMI=y
+CONFIG_DRM_ROCKCHIP=m
+CONFIG_ROCKCHIP_DW_HDMI=m
 CONFIG_DRM_RCAR_DU=m
 CONFIG_DRM_TEGRA=y
 CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=m
@@ -630,6 +632,7 @@ CONFIG_APQ_MMCC_8084=y
 CONFIG_MSM_GCC_8660=y
 CONFIG_MSM_MMCC_8960=y
 CONFIG_MSM_MMCC_8974=y
+CONFIG_ROCKCHIP_IOMMU=y
 CONFIG_TEGRA_IOMMU_GART=y
 CONFIG_TEGRA_IOMMU_SMMU=y
 CONFIG_PM_DEVFREQ=y
-- 
2.5.1

Re: [PATCH 3/4] ARM: multi_v7_defconfig: Enable Rockchip display support

[Javier Martinez Canillas]

Hello Sjoerd,

On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> Enable options needed for HDMI out on rockchip: DRM driver, Rockchip
> DesignWare HDMI glue and the rockchip IOMMU (dependency of the DRM
> driver).
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 7058fef..fb673e2 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -453,6 +453,8 @@ CONFIG_DRM_EXYNOS=m
>  CONFIG_DRM_EXYNOS_DSI=y
>  CONFIG_DRM_EXYNOS_FIMD=y
>  CONFIG_DRM_EXYNOS_HDMI=y
> +CONFIG_DRM_ROCKCHIP=m
> +CONFIG_ROCKCHIP_DW_HDMI=m
>  CONFIG_DRM_RCAR_DU=m
>  CONFIG_DRM_TEGRA=y
>  CONFIG_DRM_PANEL_SAMSUNG_S6E8AA0=m
> @@ -630,6 +632,7 @@ CONFIG_APQ_MMCC_8084=y
>  CONFIG_MSM_GCC_8660=y
>  CONFIG_MSM_MMCC_8960=y
>  CONFIG_MSM_MMCC_8974=y
> +CONFIG_ROCKCHIP_IOMMU=y
>  CONFIG_TEGRA_IOMMU_GART=y
>  CONFIG_TEGRA_IOMMU_SMMU=y
>  CONFIG_PM_DEVFREQ=y
> 

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Sjoerd Simons]

The DesignWare HS OTG USB 2.0 is used in various SoC families among wich
the various rockchip SoCs, enable the driver and the PHY glue for
rockchip

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>

---

 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index fb673e2..49c733a 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -514,6 +514,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_DWC3=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_DWC2=y
 CONFIG_AB8500_USB=y
 CONFIG_KEYSTONE_USB_PHY=y
 CONFIG_OMAP_USB3=y
@@ -658,6 +659,7 @@ CONFIG_PHY_HIX5HD2_SATA=y
 CONFIG_PWM_STI=m
 CONFIG_OMAP_USB2=y
 CONFIG_TI_PIPE3=y
+CONFIG_PHY_ROCKCHIP_USB=y
 CONFIG_PHY_MIPHY28LP=y
 CONFIG_PHY_MIPHY365X=y
 CONFIG_PHY_RCAR_GEN2=m
-- 
2.5.1

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Krzysztof Kozlowski]

On 07.09.2015 05:16, Sjoerd Simons wrote:
> The DesignWare HS OTG USB 2.0 is used in various SoC families among wich
> the various rockchip SoCs, enable the driver and the PHY glue for
> rockchip
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> 
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index fb673e2..49c733a 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -514,6 +514,7 @@ CONFIG_USB_STORAGE=y
>  CONFIG_USB_DWC3=y
>  CONFIG_USB_CHIPIDEA=y
>  CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_DWC2=y

+Cc Marek and Kukjin,

This would conflict with Marek's:
[PATCH v2] ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB
ethernet gadget
http://www.spinics.net/lists/linux-samsung-soc/msg46743.html

Probably your series and Marek's change should go together to the same
tree. How about rebasing your work on top of it?

Best regards,
Krzysztof

>  CONFIG_AB8500_USB=y
>  CONFIG_KEYSTONE_USB_PHY=y
>  CONFIG_OMAP_USB3=y
> @@ -658,6 +659,7 @@ CONFIG_PHY_HIX5HD2_SATA=y
>  CONFIG_PWM_STI=m
>  CONFIG_OMAP_USB2=y
>  CONFIG_TI_PIPE3=y
> +CONFIG_PHY_ROCKCHIP_USB=y
>  CONFIG_PHY_MIPHY28LP=y
>  CONFIG_PHY_MIPHY365X=y
>  CONFIG_PHY_RCAR_GEN2=m
> 

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Sjoerd Simons]

Hey Krzysztof,

On Mon, 2015-09-07 at 09:02 +0900, Krzysztof Kozlowski wrote:
> On 07.09.2015 05:16, Sjoerd Simons wrote:
> > The DesignWare HS OTG USB 2.0 is used in various SoC families among
> > wich
> > the various rockchip SoCs, enable the driver and the PHY glue for
> > rockchip
> +Cc Marek and Kukjin,
> 
> This would conflict with Marek's:
> [PATCH v2] ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB
> ethernet gadget
> http://www.spinics.net/lists/linux-samsung-soc/msg46743.html
> 
> Probably your series and Marek's change should go together to the
> same
> tree. How about rebasing your work on top of it?

Thanks for the pointer! I'm entirely happy to rebase on Mareks patch or
this one dropped for now until Mareks patch lands. 

These patches were based on current linux-next, so i guess Mareks pathc
didn't land just yet? Tbh, i don't really know what tries multi_v7
tends to go through (especially for non-platform specific changes)

> Best regards,
> Krzysztof
> 
> >  CONFIG_AB8500_USB=y
> >  CONFIG_KEYSTONE_USB_PHY=y
> >  CONFIG_OMAP_USB3=y
> > @@ -658,6 +659,7 @@ CONFIG_PHY_HIX5HD2_SATA=y
> >  CONFIG_PWM_STI=m
> >  CONFIG_OMAP_USB2=y
> >  CONFIG_TI_PIPE3=y
> > +CONFIG_PHY_ROCKCHIP_USB=y
> >  CONFIG_PHY_MIPHY28LP=y
> >  CONFIG_PHY_MIPHY365X=y
> >  CONFIG_PHY_RCAR_GEN2=m
> > 
> 

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Krzysztof Kozlowski]

On 07.09.2015 16:10, Sjoerd Simons wrote:
> Hey Krzysztof,
> 
> On Mon, 2015-09-07 at 09:02 +0900, Krzysztof Kozlowski wrote:
>> On 07.09.2015 05:16, Sjoerd Simons wrote:
>>> The DesignWare HS OTG USB 2.0 is used in various SoC families among
>>> wich
>>> the various rockchip SoCs, enable the driver and the PHY glue for
>>> rockchip
>> +Cc Marek and Kukjin,
>>
>> This would conflict with Marek's:
>> [PATCH v2] ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB
>> ethernet gadget
>> http://www.spinics.net/lists/linux-samsung-soc/msg46743.html
>>
>> Probably your series and Marek's change should go together to the
>> same
>> tree. How about rebasing your work on top of it?
> 
> Thanks for the pointer! I'm entirely happy to rebase on Mareks patch or
> this one dropped for now until Mareks patch lands. 
> 
> These patches were based on current linux-next, so i guess Mareks pathc
> didn't land just yet? Tbh, i don't really know what tries multi_v7
> tends to go through (especially for non-platform specific changes)

It was too late for Marek's patch to go for v4.3 merge window, so I
applied it but not pushed to my for-next branch. AFAIU, Stephen does not
want v4.4 material during merge window because of mangling with statistics.


If you want to rebase (or cherry-pick), you can find Marek's patch here:
branch: defconfig-for-next
repo: git://github.com/krzk/linux.git

However this *branch will be rebased on v4.3-rc1* (because this is
material for v4.4). After v4.3-rc1 I can prepare a tag for other
interested parties.


As for multi_v7_defconfig policy, I got impression from the
Arnd/Olof/Kevin comments on LKML, that platform specific changes should
go through platform tree. However this is multi-platform change so maybe
we can push both patches through arm-soc.


Arnd, Olof, Kevin (BTW, you missed to CC him),

How do you wish to handle this case (USB_DWC2 and two patches: Marek's
and Sjoerd's)?

Best regards,
Krzysztof

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Heiko Stübner]

Am Montag, 7. September 2015, 16:24:53 schrieb Krzysztof Kozlowski:
> On 07.09.2015 16:10, Sjoerd Simons wrote:
> > Hey Krzysztof,
> > 
> > On Mon, 2015-09-07 at 09:02 +0900, Krzysztof Kozlowski wrote:
> >> On 07.09.2015 05:16, Sjoerd Simons wrote:
> >>> The DesignWare HS OTG USB 2.0 is used in various SoC families among
> >>> wich
> >>> the various rockchip SoCs, enable the driver and the PHY glue for
> >>> rockchip
> >> 
> >> +Cc Marek and Kukjin,
> >> 
> >> This would conflict with Marek's:
> >> [PATCH v2] ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB
> >> ethernet gadget
> >> http://www.spinics.net/lists/linux-samsung-soc/msg46743.html
> >> 
> >> Probably your series and Marek's change should go together to the
> >> same
> >> tree. How about rebasing your work on top of it?
> > 
> > Thanks for the pointer! I'm entirely happy to rebase on Mareks patch or
> > this one dropped for now until Mareks patch lands.
> > 
> > These patches were based on current linux-next, so i guess Mareks pathc
> > didn't land just yet? Tbh, i don't really know what tries multi_v7
> > tends to go through (especially for non-platform specific changes)
> 
> It was too late for Marek's patch to go for v4.3 merge window, so I
> applied it but not pushed to my for-next branch. AFAIU, Stephen does not
> want v4.4 material during merge window because of mangling with statistics.
> 
> 
> If you want to rebase (or cherry-pick), you can find Marek's patch here:
> branch: defconfig-for-next
> repo: git://github.com/krzk/linux.git
> 
> However this *branch will be rebased on v4.3-rc1* (because this is
> material for v4.4). After v4.3-rc1 I can prepare a tag for other
> interested parties.
> 
> 
> As for multi_v7_defconfig policy, I got impression from the
> Arnd/Olof/Kevin comments on LKML, that platform specific changes should
> go through platform tree. However this is multi-platform change so maybe
> we can push both patches through arm-soc.
> 
> 
> Arnd, Olof, Kevin (BTW, you missed to CC him),
> 
> How do you wish to handle this case (USB_DWC2 and two patches: Marek's
> and Sjoerd's)?

I guess the easiest option would be to just drop the dwc2 from here, only 
keeping the phy enablement and let everything (Marek's and Sjoerd's patch) 
come together in the armsoc defconfig branch? As the rest of both patches don't 
seem to touch common areas, they should be easily mergable from different trees 
as well.


Heiko

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Krzysztof Kozlowski]

On 07.09.2015 16:53, Heiko Stübner wrote:
> Am Montag, 7. September 2015, 16:24:53 schrieb Krzysztof Kozlowski:
>> On 07.09.2015 16:10, Sjoerd Simons wrote:
>>> Hey Krzysztof,
>>>
>>> On Mon, 2015-09-07 at 09:02 +0900, Krzysztof Kozlowski wrote:
>>>> On 07.09.2015 05:16, Sjoerd Simons wrote:
>>>>> The DesignWare HS OTG USB 2.0 is used in various SoC families among
>>>>> wich
>>>>> the various rockchip SoCs, enable the driver and the PHY glue for
>>>>> rockchip
>>>>
>>>> +Cc Marek and Kukjin,
>>>>
>>>> This would conflict with Marek's:
>>>> [PATCH v2] ARM: multi_v7_defconfig: Enable DWC2 USB driver and USB
>>>> ethernet gadget
>>>> http://www.spinics.net/lists/linux-samsung-soc/msg46743.html
>>>>
>>>> Probably your series and Marek's change should go together to the
>>>> same
>>>> tree. How about rebasing your work on top of it?
>>>
>>> Thanks for the pointer! I'm entirely happy to rebase on Mareks patch or
>>> this one dropped for now until Mareks patch lands.
>>>
>>> These patches were based on current linux-next, so i guess Mareks pathc
>>> didn't land just yet? Tbh, i don't really know what tries multi_v7
>>> tends to go through (especially for non-platform specific changes)
>>
>> It was too late for Marek's patch to go for v4.3 merge window, so I
>> applied it but not pushed to my for-next branch. AFAIU, Stephen does not
>> want v4.4 material during merge window because of mangling with statistics.
>>
>>
>> If you want to rebase (or cherry-pick), you can find Marek's patch here:
>> branch: defconfig-for-next
>> repo: git://github.com/krzk/linux.git
>>
>> However this *branch will be rebased on v4.3-rc1* (because this is
>> material for v4.4). After v4.3-rc1 I can prepare a tag for other
>> interested parties.
>>
>>
>> As for multi_v7_defconfig policy, I got impression from the
>> Arnd/Olof/Kevin comments on LKML, that platform specific changes should
>> go through platform tree. However this is multi-platform change so maybe
>> we can push both patches through arm-soc.
>>
>>
>> Arnd, Olof, Kevin (BTW, you missed to CC him),
>>
>> How do you wish to handle this case (USB_DWC2 and two patches: Marek's
>> and Sjoerd's)?
> 
> I guess the easiest option would be to just drop the dwc2 from here, only 
> keeping the phy enablement and let everything (Marek's and Sjoerd's patch) 
> come together in the armsoc defconfig branch? As the rest of both patches don't 
> seem to touch common areas, they should be easily mergable from different trees 
> as well.

Yes, I agree. The config PHY_ROCKCHIP_USB does not depend on it directly
so this should work fine.

Best regards,
Krzysztof

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Sjoerd Simons]

On Mon, 2015-09-07 at 16:56 +0900, Krzysztof Kozlowski wrote:
> On 07.09.2015 16:53, Heiko Stübner wrote:
> > Am Montag, 7. September 2015, 16:24:53 schrieb Krzysztof Kozlowski:
> > I guess the easiest option would be to just drop the dwc2 from
> > here, only 
> > keeping the phy enablement and let everything (Marek's and Sjoerd's
> > patch) 
> > come together in the armsoc defconfig branch? As the rest of both
> > patches don't 
> > seem to touch common areas, they should be easily mergable from
> > different trees 
> > as well.
> 
> Yes, I agree. The config PHY_ROCKCHIP_USB does not depend on it
> directly
> so this should work fine.

Sounds good, I'll wait a bit longer for more feedback and then send a
V2 with patch 4 adjusted to just enable the rockchip PHY.

Thanks for the feedback!

-- 
Sjoerd Simons
Collabora Ltd.

Re: [PATCH 4/4] ARM: multi_v7_defconfig: Enable DW USB2 support and rockchip phy

[Javier Martinez Canillas]

Hello Sjoerd,

On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> The DesignWare HS OTG USB 2.0 is used in various SoC families among wich
> the various rockchip SoCs, enable the driver and the PHY glue for
> rockchip
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> 
> ---
> 
>  arch/arm/configs/multi_v7_defconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index fb673e2..49c733a 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -514,6 +514,7 @@ CONFIG_USB_STORAGE=y
>  CONFIG_USB_DWC3=y
>  CONFIG_USB_CHIPIDEA=y
>  CONFIG_USB_CHIPIDEA_HOST=y
> +CONFIG_USB_DWC2=y
>  CONFIG_AB8500_USB=y
>  CONFIG_KEYSTONE_USB_PHY=y
>  CONFIG_OMAP_USB3=y
> @@ -658,6 +659,7 @@ CONFIG_PHY_HIX5HD2_SATA=y
>  CONFIG_PWM_STI=m
>  CONFIG_OMAP_USB2=y
>  CONFIG_TI_PIPE3=y
> +CONFIG_PHY_ROCKCHIP_USB=y
>  CONFIG_PHY_MIPHY28LP=y
>  CONFIG_PHY_MIPHY365X=y
>  CONFIG_PHY_RCAR_GEN2=m
>

After dropping the DWC2 and keeping only the PHY as suggested
by Heiko and Krzysztof:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America