Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

Timothy Pearson
2025-11-07T16:13:15Z

----- Original Message -----
> From: "Jiri Slaby" <jirislaby@kernel.org>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-pci"
> <linux-pci@vger.kernel.org>, "Madhavan Srinivasan" <maddy@linux.ibm.com>, "Michael Ellerman" <mpe@ellerman.id.au>,
> "christophe leroy" <christophe.leroy@csgroup.eu>, "Naveen N Rao" <naveen@kernel.org>, "Bjorn Helgaas"
> <bhelgaas@google.com>, "Shawn Anastasio" <sanastasio@raptorengineering.com>
> Sent: Thursday, October 9, 2025 12:54:19 AM
> Subject: Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

> On 09. 10. 25, 3:24, Timothy Pearson wrote:
>> A highly unlikely NULL dereference in the allocation error handling path was
>> introduced in 466861909255. Avoid dereferencing php_slot->bus by using
>> dev_warn() instead of SLOT_WARN() in the error path.
>>
>> Fixes: 466861909255 ("PCI: pnv_php: Clean up allocated IRQs on unplug")
>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
>
> LGTM, perhaps also a lnk to the report:
> Link:
> https://lore.kernel.org/all/304758063.1694752.1757427687463.JavaMail.zimbra@raptorengineeringinc.com/
>
>
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
>
> thanks,
> --
> js
> suse labs

Just a quick follow up on this to see if we could get it merged? Thanks!