Re: [PATCH] PCI: pnv_php: Fix potential NULL dereference in slot allocator

Jiri Slaby
2025-10-09T05:54:38Z

On 09. 10. 25, 3:24, Timothy Pearson wrote:
> A highly unlikely NULL dereference in the allocation error handling path was
> introduced in 466861909255. Avoid dereferencing php_slot->bus by using
> dev_warn() instead of SLOT_WARN() in the error path.
>
> Fixes: 466861909255 ("PCI: pnv_php: Clean up allocated IRQs on unplug")
> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>

LGTM, perhaps also a lnk to the report:
Link:
https://lore.kernel.org/all/304758063.1694752.1757427687463.JavaMail.zimbra@raptorengineeringinc.com/

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
--
js
suse labs