From: David Howells <dhowells@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: dhowells@redhat.com, trix@redhat.com, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: remove trailing semicolon in macro definition
Date: Mon, 30 Nov 2020 08:58:42 +0000 [thread overview]
Message-ID: <3048453.1606726722@warthog.procyon.org.uk> (raw)
In-Reply-To: <20201129044514.GH39488@kernel.org>
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> I'm in-between whether this is worth of merging. The commit message
> does not help with that decision too much.
It is worth merging. It might cause problems for someone using it in the body
of an if-statement, say, if they don't put braces in, but do put a semicolon
on the end. I'll add it to my branch.
David
prev parent reply other threads:[~2020-11-30 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:15 [PATCH] keys: remove trailing semicolon in macro definition trix
2020-11-29 4:45 ` Jarkko Sakkinen
2020-11-29 5:30 ` Joe Perches
2020-12-02 16:45 ` Jarkko Sakkinen
2020-11-30 8:58 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3048453.1606726722@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox