From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871FCC3279B for ; Wed, 4 Jul 2018 08:00:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E67A21C3B for ; Wed, 4 Jul 2018 08:00:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E67A21C3B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934029AbeGDIAC (ORCPT ); Wed, 4 Jul 2018 04:00:02 -0400 Received: from foss.arm.com ([217.140.101.70]:60876 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932517AbeGDIAB (ORCPT ); Wed, 4 Jul 2018 04:00:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 072877A9; Wed, 4 Jul 2018 01:00:01 -0700 (PDT) Received: from [10.1.206.75] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8BECA3F5BA; Wed, 4 Jul 2018 00:59:58 -0700 (PDT) Subject: Re: [PATCH v3 4/4] arm64: dts: mediatek: add mt6765 support To: Mars Cheng Cc: Matthias Brugger , Rob Herring , Greg Kroah-Hartman , CC Hwang , Loda Chou , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, wsd_upstream@mediatek.com, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1530669174-17623-1-git-send-email-mars.cheng@mediatek.com> <1530669174-17623-5-git-send-email-mars.cheng@mediatek.com> <1530690473.16183.3.camel@mtkswgap22> From: Marc Zyngier Organization: ARM Ltd Message-ID: <304dc0a7-bcba-961c-40f4-b324ecc2d003@arm.com> Date: Wed, 4 Jul 2018 08:59:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1530690473.16183.3.camel@mtkswgap22> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/18 08:47, Mars Cheng wrote: > Hi Marc > > On Wed, 2018-07-04 at 08:35 +0100, Marc Zyngier wrote: >> On 04/07/18 02:52, Mars Cheng wrote: >>> This adds basic chip support for MT6765 SoC. >>> >>> Signed-off-by: Mars Cheng >>> --- >>> arch/arm64/boot/dts/mediatek/Makefile | 1 + >>> arch/arm64/boot/dts/mediatek/mt6765-evb.dts | 33 ++++++ >>> arch/arm64/boot/dts/mediatek/mt6765.dtsi | 155 +++++++++++++++++++++++++++ >>> 3 files changed, 189 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt6765-evb.dts >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt6765.dtsi >>> >> >> [...] >> >>> + >>> + gic: interrupt-controller@c000000 { >>> + compatible = "arm,gic-v3"; >>> + #interrupt-cells = <3>; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + #redistributor-regions = <1>; >>> + interrupt-parent = <&gic>; >>> + interrupt-controller; >>> + reg = <0 0x0c000000 0 0x40000>, // distributor >>> + <0 0x0c100000 0 0x200000>, // redistributor >>> + <0 0x0c400000 0 0x40000>; // gicc >> >> For the second time: please add *all* the GIC CPU interface regions, >> described in the Cortex-A53 TRM[1] (GICC, GICH, and GICV). >> > > MT6765 has no GICH/GICV/ITS in mediatek design. Have confirmed with our > designer. The only way *not* to have GICH or GICV is to assert GICCDISABLE on the CPU, in which case you don't have GICC either, nor any support for the GICv3 at all. So either the designer is wrong or the documentation is wrong. Which one is it, do you think? As for the ITS, that's a perfectly optional part of the design, and not part of the CPU. > MT6797 had similar question from you. Sorry for not mentioned it first. > > http://lists.infradead.org/pipermail/linux-mediatek/2017-February/008074.html Well, that's wrong too. M. -- Jazz is not dead. It just smells funny...