From: Arnd Bergmann <arnd@arndb.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andrew Duggan <aduggan@synaptics.com>,
Christopher Heiny <cheiny@synaptics.com>,
Nick Dyer <nick@shmanahar.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol
Date: Fri, 13 Jan 2017 22:06:12 +0100 [thread overview]
Message-ID: <3051252.9A92ba0o10@wuerfel> (raw)
In-Reply-To: <20170113062203.GD22630@dtor-ws>
On Thursday, January 12, 2017 10:22:03 PM CET Dmitry Torokhov wrote:
> As it was explained townthread we can't [currently] make functions
> modules, in the meantime I have d7ddad0acc4add42567f7879b116a0b9eea31860
> that should fix this issue (and I just sent pull request for it).
On today's linux-next (which includes d7ddad0acc4ad), I was still
getting this warning :
warning: (HID_RMI) selects RMI4_F03 which has unmet direct dependencies (!UML && INPUT && RMI4_CORE && (SERIO=y || RMI4_CORE=SERIO))
This is my fixup, though I'm not too happy with that version.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 1aeb80e52424..3927259a5d5d 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -785,7 +785,8 @@ config HID_SUNPLUS
config HID_RMI
tristate "Synaptics RMI4 device support"
depends on HID
- select RMI4_CORE
+ depends on SERIO && RMI4_CORE
+ depends on SERIO=y || RMI4_CORE=SERIO
select RMI4_F03
select RMI4_F11
select RMI4_F12
next prev parent reply other threads:[~2017-01-13 21:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 12:16 [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Arnd Bergmann
2017-01-11 0:39 ` Andrew Duggan
2017-01-11 15:39 ` Arnd Bergmann
2017-01-11 16:28 ` Benjamin Tissoires
2017-01-11 16:54 ` Arnd Bergmann
2017-01-11 17:48 ` Benjamin Tissoires
2017-01-11 19:27 ` Christopher Heiny
2017-01-13 0:42 ` Andrew Duggan
2017-01-13 21:14 ` Arnd Bergmann
2017-01-13 6:22 ` Dmitry Torokhov
2017-01-13 21:06 ` Arnd Bergmann [this message]
2017-01-13 21:15 ` Dmitry Torokhov
2017-01-13 21:34 ` Arnd Bergmann
2017-01-13 21:42 ` Dmitry Torokhov
2017-01-14 12:09 ` Arnd Bergmann
2017-01-15 23:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3051252.9A92ba0o10@wuerfel \
--to=arnd@arndb.de \
--cc=aduggan@synaptics.com \
--cc=cheiny@synaptics.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox