From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C79BE231CA1 for ; Mon, 10 Feb 2025 14:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739196486; cv=none; b=KECTc6EYoHAsPAcAEe7iwC3Ek/g6LR8kobz6zUQ9HWv0NPKg0qWzTofCU4QpoCCsEV3x/3Z5bqB+CHOH2KUFCHBNV11mmIvTXsAR1r65qfmOQuhVORi3OltYOo/fAD4+XJarvax7mnwygA1ctj29a2OM6VLtVW9YTObfhq6/mCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739196486; c=relaxed/simple; bh=Qnyg4AhO7AlWzaAjgnfboS2ahykzojmyYz/dy7vhqn4=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=HcsaWTnD2e/kLsB3g79czqjS8v0cW/ArfPbXMNeznf1ueISdNniFkC31CzOf8utjBSuvHnBW9RzUG041r3mry+gF3xx1TshX+8v7NAzTo2nlx9rRBwk08JyWr6z4okpzJBCUzquyShsCIj2k5ihsSQMt6dHnLm6EPiWjlfwnlkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WilqNpZB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WilqNpZB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739196483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sNF2zPwPgiY6vDrjo37ivtvlQa7hoNvAO5mHqkBo7W0=; b=WilqNpZBhpOk7PfJN7MXipmbSuNdozBt/np4rXUkcts44+ox4FSOl10ZuORHstpSLMDYaI IoN8QjGZaQGL0hlTHfNgAEUrtzstXCzJUyU3qsE5fiTySfP6gRW1Ohbiid0cXbvwhi3FVD U+SCW+hyZZLDazXSlBkJd5ZeDd+H8ck= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-SyPxNyfjPEedBtdoOq5Ryw-1; Mon, 10 Feb 2025 09:07:58 -0500 X-MC-Unique: SyPxNyfjPEedBtdoOq5Ryw-1 X-Mimecast-MFC-AGG-ID: SyPxNyfjPEedBtdoOq5Ryw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9FC581955D8E; Mon, 10 Feb 2025 14:07:49 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.92]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 38B7B3001D19; Mon, 10 Feb 2025 14:07:48 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Max Kellermann Cc: dhowells@redhat.com, netfs@lists.linux.dev, LKML , linux-nfs@vger.kernel.org Subject: Re: "netfs: Can't donate prior to front" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3052001.1739196466.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Mon, 10 Feb 2025 14:07:46 +0000 Message-ID: <3052002.1739196466@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Can you apply the attached patch to your kernel, and then run with: echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_read/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_rreq/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_sreq/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_failure/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_donate/enable echo 1 >/sys/kernel/debug/tracing/events/netfs/netfs_progress/enable enabled. If you can capture the trace output (and compress it!), that sho= uld hopefully help debug this. David diff --git a/fs/netfs/read_collect.c b/fs/netfs/read_collect.c index e8624f5c7fcc..8b78c1ec0677 100644 --- a/fs/netfs/read_collect.c +++ b/fs/netfs/read_collect.c @@ -312,6 +312,7 @@ static bool netfs_consume_read_data(struct netfs_io_su= brequest *subreq, bool was printk("folio: %llx-%llx\n", fpos, fend - 1); printk("donated: prev=3D%zx next=3D%zx\n", prev_donated, next_donated); printk("s=3D%llx av=3D%zx part=3D%zx\n", start, avail, part); + tracing_off(); BUG(); } =