From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932128AbcELJZs (ORCPT ); Thu, 12 May 2016 05:25:48 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53656 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbcELJZp (ORCPT ); Thu, 12 May 2016 05:25:45 -0400 From: Markus Pargmann To: Pranay Srivastava Cc: nbd-general@lists.sourceforge.net, Eric Blake , Greg KH , linux-kernel@vger.kernel.org Subject: Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning. Date: Thu, 12 May 2016 11:25:37 +0200 Message-ID: <3058000.fnjPHtag2K@adelgunde> User-Agent: KMail/4.14.1 (Linux/4.5.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <573337B1.6030900@redhat.com> References: <1462954726-11825-1-git-send-email-pranjas@gmail.com> <573337B1.6030900@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3573717.MKC9iGAX6l"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 2001:67c:670:100:a61f:72ff:fe68:75ba X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3573717.MKC9iGAX6l Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Hi, On Wednesday 11 May 2016 07:46:25 Eric Blake wrote: > On 05/11/2016 03:38 AM, Pranay Srivastava wrote: >=20 > >=20 > > The series contained some checkpatch changes so I had included you = as well. > >=20 > >> know why you are sending them to me), but I know I do not accept p= atches > >> without any changelog text at all in them, as that's just lazy. > >=20 > > That should be per patch or can appear in a cover letter for the pa= tches? >=20 > Per patch. However, if it were me, I would not have split into quite= so > many patches. The mantra is one patch per one fix, but I think it is= > reasonable to state that "silence all checkpatch warnings" counts as = one > fix, rather than 16 separate fixes. If you DO consolidate the > checkpatch changes into a single patch, then the commit message body > should call out a bulleted list of all the changes you are making, as= > well as a justification why it is worth churning the entire file rath= er > than just making smaller checkpatch fixes in just the areas that your= > other patches touch. Yes, I think about this similarly. There is simply no benefit in having= the history full of patches that partly even have the exact same subject. So please squash them into one and describe your changes in th= e commit message. Thanks, Markus >=20 > >=20 > > Actually I've made more patches in this series after I had sent the= > > earlier ones, > > but the earlier ones are not changed at all. It's only the addition= of > > newer patches > > to the series. >=20 > The cover letter is a great place to point out how v4 differs from v3= , > but also to point out which patches are unchanged from v3, to save > reviewer's time. So if all you did was add new patches, a cover-lett= er > mention of which patches remain unchanged might be helpful. >=20 >=20 =2D-=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | --nextPart3573717.MKC9iGAX6l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXNEwRAAoJEEpcgKtcEGQQL34QAIp1Aoqc3qPjTade9HSN6h3h LYszoYwxna+HFTpiBiq/kwDTQ5hNZoA1xAVEzGPUkFZeCmpnzRs0u3Mh2ua5udOf Sfr9pRLu8k/GtFYwJWcHDpn61tq6w7xv5oJTRwH5maM+zSUAWK0y+BHnUjBV/4mU M9bu4Im/nn/aRkmsh0g4/ubzTjMN92berEH1RgFCwkKAPoB0s4yBOVk9cDOc6s+L T84RV/F5hP9TrVVQlXWXA+MCewAIlTuUUZvYvzcQsYYiWF5TaPQtnzEWlauL/+OU mt8xwofC/saZuBI3u4PrGOS3gxCY7Yiymbb9J7ISlsn6aUIE1ayxFwZH5vpM0pLe 2d0Vg/K+z+m9LiyPlpTqtNjwjcaB2XjIcUE1XHSCsWrbcZie0dJ1SBI+noRDu2z2 2KTkULZCBSNK+RL8Kpl/2JRAuRQJcq5FqeGScy5fJpp2bAqjjtKZvzWTOLoCQRW9 LW3SiaYM093QuOO/Hqmw0wQWZmdITkm2aNhgMyCsD9kuB79PBk2wljSfDYcrnwqf Gy5pSApAorM9K2PJFQfgo66akyPGgVT1D2d9XBvqE58Y1iuu919q73NXR5uQpxpg V8cZn8wcDsk4dms4l/LFfOu3Zus06lUK9A+wNOmhmHSGfDkWoWShdelwQT3/ZhcK oqfu0PyeRlxpXKoV4DE0 =yxsY -----END PGP SIGNATURE----- --nextPart3573717.MKC9iGAX6l--