Re: [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk()

Joe Perches
2013-09-26T15:38:15Z

On Thu, 2013-09-26 at 16:35 +0100, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
>
> > no_printk doesn't prevent any argument side-effects
> > from being optimized away by the compiler.
> >
> > ie:
> > dprintk("%d", func())
> > func is now always called when before it wasn't.
>
> Yes, I know. There are half a dozen places where this is the case. Those
> I've wrapped in ifdebug(FACILITY) { ... } in the code. It's not the nicest,
> but at least the compiler always gets to see everything, rather than bits of
> it getting hidden by the preprocessor - which means the call points will be
> less likely to bit rot over time.

No code is eliminated by the preprocessor
with the #define I suggest.