RE: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in

Myklebust, Trond
2013-09-26T15:23:47Z

> -----Original Message-----
> From: J. Bruce Fields [mailto:bfields@fieldses.org]
> Sent: Thursday, September 26, 2013 10:21 AM
> To: David Howells
> Cc: Myklebust, Trond; olof@lixom.net; linux-nfs@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in
>
> On Thu, Sep 26, 2013 at 03:45:02PM +0100, David Howells wrote:
> >
> >
> > Here's a series of patches to make SunRPC/NFS use no_printk() to
> > implement its null dfprintk() macro (ie. when RPC_DEBUG is disabled).
> > This prevents 'unused variable' errors from occurring when a variable
> > is set only for use in debugging statements and renders RPC/NFS_IFDEBUG
> unnecessary.
>
> Does this patch series fix any actual warnings? Or does it just change the way
> that we prevent the warnings?
>

Right. If this is just code churn, then let's drop it. Otherwise, please explain why it is a good idea.

Cheers,
Trond