Re: [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk()

David Howells
2013-09-26T15:42:59Z

Joe Perches <joe@perches.com> wrote:

> No code is eliminated by the preprocessor
> with the #define I suggest.

Sorry, I misunderstood. I assumed you meant comparing to:

#ifdef RPC_DEBUG
#define dfprintk(...) ...
#else
#define dfprintk(...) do {} while(0)
#endif

sort of thing which would certainly eliminate code in cpp.

So, yes, you're right. So I shouldn't need to put the

ifdebug(FACILITY) { ... }

clauses into the code as the function calls in the argument list will be
behind the if-statement anyway.

David