From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935494AbbI2SrZ (ORCPT ); Tue, 29 Sep 2015 14:47:25 -0400 Received: from mail-qg0-f49.google.com ([209.85.192.49]:34292 "EHLO mail-qg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935252AbbI2SrR (ORCPT ); Tue, 29 Sep 2015 14:47:17 -0400 From: Paul Moore To: Yaowei Bai Cc: eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] kernel/audit: audit_tree_match can be boolean Date: Tue, 29 Sep 2015 14:47:15 -0400 Message-ID: <3064629.WSR5t3yA0n@sifl> User-Agent: KMail/4.14.10 (Linux/4.1.5-gentoo; KDE/4.14.12; x86_64; ; ) In-Reply-To: <1443536141-5134-3-git-send-email-bywxiaobai@163.com> References: <1443536141-5134-1-git-send-email-bywxiaobai@163.com> <1443536141-5134-3-git-send-email-bywxiaobai@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, September 29, 2015 10:15:41 PM Yaowei Bai wrote: > This patch makes audit_tree_match return bool to improve readability > due to this particular function only using either one or zero as its > return value. > > No functional change. > > Signed-off-by: Yaowei Bai > --- > kernel/audit.h | 2 +- > kernel/audit_tree.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/kernel/audit.h b/kernel/audit.h > index dadf86a..de6cbb7 100644 > --- a/kernel/audit.h > +++ b/kernel/audit.h > @@ -301,7 +301,7 @@ extern int audit_exe_compare(struct task_struct *tsk, > struct audit_fsnotify_mark #ifdef CONFIG_AUDIT_TREE > extern struct audit_chunk *audit_tree_lookup(const struct inode *); > extern void audit_put_chunk(struct audit_chunk *); > -extern int audit_tree_match(struct audit_chunk *, struct audit_tree *); > +extern bool audit_tree_match(struct audit_chunk *, struct audit_tree *); > extern int audit_make_tree(struct audit_krule *, char *, u32); > extern int audit_add_tree_rule(struct audit_krule *); > extern int audit_remove_tree_rule(struct audit_krule *); > diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c > index 94ecdab..5efe9b29 100644 > --- a/kernel/audit_tree.c > +++ b/kernel/audit_tree.c > @@ -197,13 +197,13 @@ struct audit_chunk *audit_tree_lookup(const struct > inode *inode) return NULL; > } > > -int audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree) > +bool audit_tree_match(struct audit_chunk *chunk, struct audit_tree *tree) > { > int n; > for (n = 0; n < chunk->count; n++) > if (chunk->owners[n].owner == tree) > - return 1; > - return 0; > + return true; > + return false; > } > > /* tagging and untagging inodes with trees */ -- paul moore www.paul-moore.com