* Re: [lm-sensors] [PATCH] lm75: some optimisations [not found] <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com> @ 2010-09-09 17:55 ` Guenter Roeck 2010-09-09 18:11 ` Jean Delvare 0 siblings, 1 reply; 4+ messages in thread From: Guenter Roeck @ 2010-09-09 17:55 UTC (permalink / raw) To: Shubhrajyoti D; +Cc: lm-sensors@lm-sensors.org, linux-kernel, Jean Delvare General comments: - Please select a more descriptive headline, such as hwmon: lm75: Add __devinit and __devexit section initializers - It is useful to provide the patch version to reduce confusion and enable version tracking. Example: [PATCH v3] hwmon: lm75: Add __devinit and __devexit section initializers - Please cc linux-kernel@vger.kernel.org and Jean Delvare <khali@linux-fr.org>. On Thu, Sep 09, 2010 at 01:12:16PM -0400, Shubhrajyoti D wrote: > - updating with Guenter's comments > This and other patch version related comments should be below the --- line. Otherwise, it will end up in the commit log, which isn't really useful. > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> Assuming you make above changes and resubmit, feel free to add Reviewed-by: Guenter Roeck <guenter.roeck@ericsson.com> Guenter > --- > drivers/hwmon/lm75.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c > index ab5b87a..028f961 100644 > --- a/drivers/hwmon/lm75.c > +++ b/drivers/hwmon/lm75.c > @@ -134,7 +134,7 @@ static const struct attribute_group lm75_group = { > > /* device probe and removal */ > > -static int > +static int __devinit > lm75_probe(struct i2c_client *client, const struct i2c_device_id *id) > { > struct lm75_data *data; > @@ -196,7 +196,7 @@ exit_free: > return status; > } > > -static int lm75_remove(struct i2c_client *client) > +static int __devexit lm75_remove(struct i2c_client *client) > { > struct lm75_data *data = i2c_get_clientdata(client); > > @@ -325,7 +325,7 @@ static struct i2c_driver lm75_driver = { > .pm = LM75_DEV_PM_OPS, > }, > .probe = lm75_probe, > - .remove = lm75_remove, > + .remove = __devexit_p(lm75_remove), > .id_table = lm75_ids, > .detect = lm75_detect, > .address_list = normal_i2c, > -- > 1.7.0.4 > > > _______________________________________________ > lm-sensors mailing list > lm-sensors@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] lm75: some optimisations 2010-09-09 17:55 ` [lm-sensors] [PATCH] lm75: some optimisations Guenter Roeck @ 2010-09-09 18:11 ` Jean Delvare 2010-09-13 4:10 ` Valdis.Kletnieks 0 siblings, 1 reply; 4+ messages in thread From: Jean Delvare @ 2010-09-09 18:11 UTC (permalink / raw) To: Guenter Roeck; +Cc: Shubhrajyoti D, lm-sensors, linux-kernel On Thu, 9 Sep 2010 10:55:37 -0700, Guenter Roeck wrote: > General comments: > > - Please select a more descriptive headline, such as > hwmon: lm75: Add __devinit and __devexit section initializers > > - It is useful to provide the patch version to reduce confusion and enable > version tracking. > Example: > [PATCH v3] hwmon: lm75: Add __devinit and __devexit section initializers > > - Please cc linux-kernel@vger.kernel.org and Jean Delvare <khali@linux-fr.org>. Please do NOT CC linux-kernel@vger.kernel.org. We have a mailing list dedicated to hardware monitoring, there's no point to add to the 200,000 messages (literally) LKML gets every year. The more messages a list gets, the fewer readers it has. As for CC'ing me, it doesn't hurt, but doesn't make a difference either, as I read the lm-sensors list carefully anyway. -- Jean Delvare ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] lm75: some optimisations 2010-09-09 18:11 ` Jean Delvare @ 2010-09-13 4:10 ` Valdis.Kletnieks 2010-09-13 8:03 ` Jean Delvare 0 siblings, 1 reply; 4+ messages in thread From: Valdis.Kletnieks @ 2010-09-13 4:10 UTC (permalink / raw) To: Jean Delvare; +Cc: Guenter Roeck, Shubhrajyoti D, lm-sensors, linux-kernel [-- Attachment #1: Type: text/plain, Size: 462 bytes --] On Thu, 09 Sep 2010 20:11:28 +0200, Jean Delvare said: > Please do NOT CC linux-kernel@vger.kernel.org. We have a mailing list > dedicated to hardware monitoring, there's no point to add to the 200,000 > messages (literally) LKML gets every year. The more messages a list > gets, the fewer readers it has. Any way to represent this in the MAINTAINERS file, so that people who come along in the fugure know that lm-sensors gets special handling in that regard? [-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH] lm75: some optimisations 2010-09-13 4:10 ` Valdis.Kletnieks @ 2010-09-13 8:03 ` Jean Delvare 0 siblings, 0 replies; 4+ messages in thread From: Jean Delvare @ 2010-09-13 8:03 UTC (permalink / raw) To: Valdis.Kletnieks; +Cc: Guenter Roeck, Shubhrajyoti D, lm-sensors, linux-kernel On Mon, 13 Sep 2010 00:10:00 -0400, Valdis.Kletnieks@vt.edu wrote: > On Thu, 09 Sep 2010 20:11:28 +0200, Jean Delvare said: > > > Please do NOT CC linux-kernel@vger.kernel.org. We have a mailing list > > dedicated to hardware monitoring, there's no point to add to the 200,000 > > messages (literally) LKML gets every year. The more messages a list > > gets, the fewer readers it has. > > Any way to represent this in the MAINTAINERS file, so that people who come > along in the fugure know that lm-sensors gets special handling in that regard? Unfortunately not. The only way would be to convince the maintainers of scripts/get_maintainer.pl to NOT unconditionally add LKML to its output. -- Jean Delvare ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-09-13 8:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1284052336-25864-1-git-send-email-shubhrajyoti@ti.com>
2010-09-09 17:55 ` [lm-sensors] [PATCH] lm75: some optimisations Guenter Roeck
2010-09-09 18:11 ` Jean Delvare
2010-09-13 4:10 ` Valdis.Kletnieks
2010-09-13 8:03 ` Jean Delvare
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox