Re: [RFC PATCH] ima: audit log files opened with O_DIRECT flag

Mimi Zohar
2014-05-13T11:11:53Z

On Tue, 2014-05-13 at 16:19 +0900, J. R. Okajima wrote:
> Mimi Zohar:
> > As a temporary fix, do not measure, appraise, or audit files
> > opened with the O_DIRECT flag set. Just audit log it.
>
> I have no objection about the patch, but have a question.
> Are you intending to put it into mainline now (and stable too)? Or is
> this a local bandage for whoever have met the problem (like me)?

Yes, for the time being.

> In other words, should I wait for another lock free solution from Dmitry
> Kasatkin?

In addition to the lockdep issue, there is a separate problem of reading
the file opened w/O_DIRECT flag. Dmitry is about to post two patches,
with a detailed explanation. The first patch re-introduces the
iint->mutex. The other patch reads the file opened w/O_DIRECT flag.
Neither patch is trivial.

> By the way, the mail is not delivered to stable-ML while there is
> "Cc: stable..." line in the commit log.

The CC shouldn't have been included in an RFC.

Mimi