* [PATCH] frv: Remove bogus NO_IRQ = -1 define
@ 2007-11-07 16:53 Alan Cox
2007-11-07 17:28 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2007-11-07 16:53 UTC (permalink / raw)
To: dhowells, linux-kernel; +Cc: torvalds
The old NO_IRQ define some platforms had was long ago declared obsolete
and wrong. FRV should therefore not be re-introducing this, especially as
IRQs are usually unsigned in the kernel. The "no IRQ" case is defined to be
zero and Linus made this rather clear at the time.
arch/frv shows no dependancy on this but it might show up driver fixes
needing doing I guess
Signed-off-by: Alan Cox <alan@redhat.com>
--- include/asm-frv//irq.h~ 2007-11-07 16:35:09.927759328 +0000
+++ include/asm-frv/irq.h 2007-11-07 16:35:09.944756744 +0000
@@ -12,9 +12,6 @@
#ifndef _ASM_IRQ_H_
#define _ASM_IRQ_H_
-/* this number is used when no interrupt has been assigned */
-#define NO_IRQ (-1)
-
#define NR_IRQS 48
#define IRQ_BASE_CPU (0 * 16)
#define IRQ_BASE_FPGA (1 * 16)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] frv: Remove bogus NO_IRQ = -1 define
2007-11-07 16:53 [PATCH] frv: Remove bogus NO_IRQ = -1 define Alan Cox
@ 2007-11-07 17:28 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2007-11-07 17:28 UTC (permalink / raw)
To: Alan Cox; +Cc: dhowells, linux-kernel, torvalds
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> The old NO_IRQ define some platforms had was long ago declared obsolete
> and wrong. FRV should therefore not be re-introducing this, especially as
> IRQs are usually unsigned in the kernel. The "no IRQ" case is defined to be
> zero and Linus made this rather clear at the time.
>
> arch/frv shows no dependancy on this but it might show up driver fixes
> needing doing I guess
FRV doesn't use IRQ 0, so using 0 instead is fine.
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-07 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-07 16:53 [PATCH] frv: Remove bogus NO_IRQ = -1 define Alan Cox
2007-11-07 17:28 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox