From: Arnd Bergmann <arnd@arndb.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Pi-Cheng Chen <pi-cheng.chen@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: cpufreq: mediatek: allow modular build
Date: Fri, 11 Sep 2015 10:36:19 +0200 [thread overview]
Message-ID: <3071823.f1VzTWVMmV@wuerfel> (raw)
In-Reply-To: <20150911082536.GL9650@linux>
On Friday 11 September 2015 13:55:36 Viresh Kumar wrote:
> On 11-09-15, 10:22, Arnd Bergmann wrote:
> > In my approach, I decided to allow the driver to be a module, as that
> > seems nicer for multi_v7_defconfig, but I now see that there are
> > several other drivers that can only be built-in, so if we decided to
> > make that the general strategy we should change them all.
>
> And we need to do that with a proper module_exit() function, otherwise
> we are really adding a BUG. Which you just did with your patch
I don't consider that a bug: a module with just an init function and
no exit function can be loaded once and never unloaded, which is not
nice for debugging, but is otherwise fully functional.
Arnd
next prev parent reply other threads:[~2015-09-11 8:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 8:15 cpufreq: mediatek: allow modular build Arnd Bergmann
2015-09-11 8:17 ` Viresh Kumar
2015-09-11 8:22 ` Arnd Bergmann
2015-09-11 8:25 ` Viresh Kumar
2015-09-11 8:36 ` Arnd Bergmann [this message]
2015-09-11 8:38 ` Viresh Kumar
2015-09-11 9:34 ` Russell King - ARM Linux
2015-09-11 9:40 ` Viresh Kumar
2015-09-11 9:58 ` Russell King - ARM Linux
2015-09-11 10:09 ` Viresh Kumar
2015-09-11 10:13 ` Russell King - ARM Linux
2015-09-11 10:19 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3071823.f1VzTWVMmV@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pi-cheng.chen@linaro.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox