From: David Howells <dhowells@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: dhowells@redhat.com, netdev@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] rxrpc: Fix missing IPV6 #ifdef
Date: Thu, 10 Nov 2022 14:09:45 +0000 [thread overview]
Message-ID: <3080953.1668089385@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y20A33ya17l/MqxU@lunn.ch>
Andrew Lunn <andrew@lunn.ch> wrote:
> > +#ifdef CONFIG_AF_RXRPC_IPV6
> > return ipv6_icmp_error(sk, skb, err, port, info, payload);
> > +#endif
>
> Can this be if (IS_ENABLED(CONFIG_AF_RXRPC_IPV6) {} rather than
> #ifdef? It gives better build testing.
Sure. Does it actually make that much of a difference? I guess the
declaration is there even if IPV6 is disabled.
David
next prev parent reply other threads:[~2022-11-10 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 9:43 [PATCH net-next] rxrpc: Fix missing IPV6 #ifdef David Howells
2022-11-10 10:42 ` Hideaki Yoshifuji
2022-11-10 13:26 ` David Howells
2022-11-10 13:47 ` Andrew Lunn
2022-11-10 14:09 ` David Howells [this message]
2022-11-10 15:37 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3080953.1668089385@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=andrew@lunn.ch \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox