From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0F5C4708D for ; Thu, 29 Dec 2022 15:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233656AbiL2P5E (ORCPT ); Thu, 29 Dec 2022 10:57:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233723AbiL2P4g (ORCPT ); Thu, 29 Dec 2022 10:56:36 -0500 Received: from mail.holmansrus.com (unknown [143.59.183.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88FDF2BF for ; Thu, 29 Dec 2022 07:54:43 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.holmansrus.com (Postfix) with ESMTP id 9831EE1D8B; Thu, 29 Dec 2022 09:54:42 -0600 (CST) Received: from mail.holmansrus.com ([127.0.0.1]) by localhost (mail.holmansrus.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SFOQwsu4wpPp; Thu, 29 Dec 2022 09:54:41 -0600 (CST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.holmansrus.com (Postfix) with ESMTP id BBC9FE1D81; Thu, 29 Dec 2022 09:54:41 -0600 (CST) X-Virus-Scanned: amavisd-new at holmansrus.com Received: from mail.holmansrus.com ([127.0.0.1]) by localhost (mail.holmansrus.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id qCojwFhzkrdt; Thu, 29 Dec 2022 09:54:41 -0600 (CST) Received: from mail.holmansrus.com (mail.holmansrus.com [10.90.0.246]) by mail.holmansrus.com (Postfix) with ESMTP id 8E3BBE1D82; Thu, 29 Dec 2022 09:54:41 -0600 (CST) Date: Thu, 29 Dec 2022 09:54:41 -0600 (CST) From: Walt Holman To: Greg KH Cc: linux-kernel Message-ID: <308147064.5.1672329281388.JavaMail.zimbra@holmansrus.com> In-Reply-To: References: <933489772.83.1672266579857.JavaMail.zimbra@holmansrus.com> Subject: Re: [PATCH 6.1 0000/1146] 6.1.2-rc1 review MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.90.0.246] X-Mailer: Zimbra 8.8.15_GA_4484 (ZimbraWebClient - GC108 (Linux)/8.8.15_GA_4481) Thread-Topic: 6.1.2-rc1 review Thread-Index: FQOn6q/XNZPwbOB/ytDSaiKZEiPvAQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- On Dec 29, 2022, at 1:13 AM, Greg KH gregkh@linuxfoundation.org wrote: > On Wed, Dec 28, 2022 at 04:29:39PM -0600, Walt Holman wrote: >> > This is the start of the stable review cycle for the 6.1.2 release. >> > There are 1146 patches in this series, all will be posted as a response >> > to this one. If anyone has any issues with these being applied, please >> > let me know. >> > >> > Responses should be made by Fri, 30 Dec 2022 14:41:29 +0000. >> > Anything received after that time might be too late. >> > >> > The whole patch series can be found in one patch at: >> > [ https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.2-rc1.gz >> > | https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.2-rc1.gz >> > ] > or in the git tree and branch at: >> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >> > linux-6.1.y >> > and the diffstat can be found below. >> > >> > thanks, >> > >> > greg k-h >> > >> > ------------- >> >> Hello, >> >> I'm getting a NULL Pointer Dereference when shutting down or rebooting. It >> happens just as it tries to shut down the swap device ( /dev/dm-3 ). This >> happens late in the shutdown process and nothing gets saved in the logs. >> However, I've attached a photo of my screen showing the Oops and stack trace. >> Let me know if there's anything you'd like me to try. > > Does this happen with 6.1.1 also? > > Can you use 'git bisect' to track down the offending change? > > thanks, > > greg k-h Bisecting the kernel results in the following: 273d29fa4beb3954c970b6377a2aa6ee442b1430 is the first bad commit commit 273d29fa4beb3954c970b6377a2aa6ee442b1430 Author: Christoph Hellwig Date: Tue Nov 1 16:00:47 2022 +0100 blk-mq: move the srcu_struct used for quiescing to the tagset [ Upstream commit 80bd4a7aab4c9ce59bf5e35fdf52aa23d8a3c9f5 ] All I/O submissions have fairly similar latencies, and a tagset-wide quiesce is a fairly common operation. Signed-off-by: Christoph Hellwig Reviewed-by: Keith Busch Reviewed-by: Ming Lei Reviewed-by: Chao Leng Reviewed-by: Sagi Grimberg Reviewed-by: Hannes Reinecke Reviewed-by: Chaitanya Kulkarni Link: https://lore.kernel.org/r/20221101150050.3510-12-hch@lst.de [axboe: fix whitespace] Signed-off-by: Jens Axboe Stable-dep-of: d36a9ea5e776 ("block: fix use-after-free of q->q_usage_counter") Signed-off-by: Sasha Levin block/blk-core.c | 27 +++++---------------------- block/blk-mq.c | 33 +++++++++++++++++++++++++-------- block/blk-mq.h | 14 +++++++------- block/blk-sysfs.c | 9 ++------- block/blk.h | 9 +-------- block/genhd.c | 2 +- include/linux/blk-mq.h | 4 ++++ include/linux/blkdev.h | 9 --------- 8 files changed, 45 insertions(+), 62 deletions(-) -Walt