From: Tetsuhiro Kohada <kohada.t2@gmail.com>
To: Sungjong Seo <sj1557.seo@samsung.com>
Cc: kohada.tetsuhiro@dc.mitsubishielectric.co.jp,
mori.takahiro@ab.mitsubishielectric.co.jp,
motai.hirotaka@aj.mitsubishielectric.co.jp,
'Namjae Jeon' <namjae.jeon@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] exfat: redefine PBR as boot_sector
Date: Fri, 29 May 2020 15:32:11 +0900 [thread overview]
Message-ID: <308405a2-429d-b9aa-ca1c-a699570ae112@gmail.com> (raw)
In-Reply-To: <0bd201d63579$f9b03d00$ed10b700$@samsung.com>
>> I'll make another small patch, OK?
>
> No, It make sense to make v3, because you have renamed the variables in
> boot_sector on this patch.
OK.
>> BTW
>> I have a concern about fs_name.
>> The exfat specification says that this field is "EXFAT".
>>
>> I think it's a important field for determining the filesystem.
>> However, in this patch, I gave up checking this field.
>> Because there is no similar check in FATFS.
>> Do you know why Linux FATFS does not check this filed?
>> And, what do you think of checking this field?
>
> FATFS has the same field named "oem_name" and whatever is okay for its value.
> However, in case of exFAT, it is an important field to determine filesystem.
>
> I think it would be better to check this field for exFAT-fs.
> Would you like to contribute new patch for checking it?
I already have the code, so I'll add it to [PATCH 2/4 v3].
BR
prev parent reply other threads:[~2020-05-29 6:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200525115110epcas1p491bfb477b12825536e81e376f34c7a02@epcas1p4.samsung.com>
2020-05-25 11:50 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 2/4] exfat: separate the boot sector analysis Tetsuhiro Kohada
2020-05-25 11:50 ` [PATCH 3/4] exfat: add boot region verification Tetsuhiro Kohada
2020-05-26 7:23 ` Namjae Jeon
2020-05-29 16:51 ` kbuild test robot
2020-05-25 11:50 ` [PATCH 4/4] exfat: standardize checksum calculation Tetsuhiro Kohada
2020-05-26 7:32 ` Namjae Jeon
2020-05-27 7:39 ` Tetsuhiro Kohada
2020-05-27 11:28 ` Namjae Jeon
2020-05-28 2:00 ` Tetsuhiro Kohada
2020-05-28 5:03 ` Namjae Jeon
2020-05-28 10:09 ` Tetsuhiro Kohada
2020-05-28 11:30 ` Namjae Jeon
2020-05-28 5:31 ` [PATCH 1/4] exfat: redefine PBR as boot_sector Sungjong Seo
2020-05-28 12:27 ` Tetsuhiro Kohada
2020-05-29 5:28 ` Sungjong Seo
2020-05-29 6:32 ` Tetsuhiro Kohada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=308405a2-429d-b9aa-ca1c-a699570ae112@gmail.com \
--to=kohada.t2@gmail.com \
--cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mori.takahiro@ab.mitsubishielectric.co.jp \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox