From: David Howells <dhowells@redhat.com>
To: kamezawa.hiroyu@jp.fujitsu.com, torvalds@osdl.org
Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: sync_mm_rss() issues
Date: Mon, 08 Mar 2010 13:59:56 +0000 [thread overview]
Message-ID: <30859.1268056796@redhat.com> (raw)
There are a couple of issues with sync_mm_rss(), as added by patch:
commit 34e55232e59f7b19050267a05ff1226e5cd122a5
Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Date: Fri Mar 5 13:41:40 2010 -0800
Subject: mm: avoid false sharing of mm_counter
(1) You haven't implemented it for NOMMU mode. What's the right way to do
this? Just give an empty function?
(2) linux/mm.h should carry the empty function as an inline when
CONFIG_SPLIT_RSS_COUNTING=n, rather than it being defined as an empty
function in mm/memory.c.
David
next reply other threads:[~2010-03-08 14:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 13:59 David Howells [this message]
2010-03-08 23:50 ` sync_mm_rss() issues KAMEZAWA Hiroyuki
2010-03-09 0:58 ` [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was " KAMEZAWA Hiroyuki
2010-03-09 2:33 ` Mike Frysinger
2010-03-09 11:49 ` Michal Simek
2010-03-09 15:41 ` Christoph Lameter
2010-03-09 15:43 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30859.1268056796@redhat.com \
--to=dhowells@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).