From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>, Felipe Balbi <balbi@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk
Date: Thu, 13 Apr 2023 08:04:56 +0000 [thread overview]
Message-ID: <30861bce0ef44bdea36b2c90ec033850@realtek.com> (raw)
In-Reply-To: <2d058629-bd97-5e4d-8630-598cc22e5c58@kernel.org>
> On 13/04/2023 05:03, Stanley Chang wrote:
> > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for
> > disable the high-speed parkmode.
>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives
> you outdated entries. Therefore please be sure you base your patches on
> recent Linux kernel.
>
> It's the second time I am writing it. I don't understand why you keep ignoring
> it.
Sorry for the confusion.
In the beginning I didn't have cc all maintainers.
I'll resubmit a new review thread.
Please ignore this email.
> Your commit msg does not explain why do we need it.
I will add it at new patch.
> >
> > Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> > ---
> > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > index be36956af53b..45ca967b8d14 100644
> > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> > @@ -232,6 +232,11 @@ properties:
> > When set, all SuperSpeed bus instances in park mode are disabled.
> > type: boolean
> >
> > + snps,parkmode-disable-hs-quirk:
> > + description:
> > + When set, all HighSpeed bus instances in park mode are disabled.
>
> Why?
>
For some USB wifi devices, if enable this feature it will reduce the
performance. Therefore, add an option for disabling HS park mode by device-tree.
Thanks,
Stanley
prev parent reply other threads:[~2023-04-13 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230411053550.16360-1-stanley_chang@realtek.com>
[not found] ` <20230411213158.r7i6thg67okbovjp@synopsys.com>
2023-04-12 11:15 ` [PATCH v2 1/2] usb: dwc3: core: add support for disabling High-speed park mode Stanley Chang[昌育德]
2023-04-13 7:41 ` Greg Kroah-Hartman
2023-04-13 8:00 ` Stanley Chang[昌育德]
[not found] ` <20230411053550.16360-2-stanley_chang@realtek.com>
[not found] ` <42476475-3de1-49e8-4cfe-a9b3d98df8be@kernel.org>
2023-04-12 11:10 ` [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk Stanley Chang[昌育德]
2023-04-12 14:16 ` Krzysztof Kozlowski
2023-04-13 3:03 ` Stanley Chang
2023-04-13 7:34 ` Krzysztof Kozlowski
2023-04-13 8:04 ` Stanley Chang[昌育德] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30861bce0ef44bdea36b2c90ec033850@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox