From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 2/5] dt-bindings: crypto: ice: add freq-table-hz property to ICE schema
Date: Thu, 9 Oct 2025 17:21:52 +0900 [thread overview]
Message-ID: <3087bab4-3eea-485a-a6e6-de14ebf2825c@kernel.org> (raw)
In-Reply-To: <20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-2-2a34d8d03c72@oss.qualcomm.com>
On 09/10/2025 15:18, Abhinaba Rakshit wrote:
> Introduce the 'freq-table-hz' property to specify the minimum and maximum
> frequencies supported by the Inline Crypto Engine (ICE) clock.
>
> This property is added to the ICE device node because the ICE clock is
> managed independently by the ICE driver and requires frequency information
> to be available in the device tree for the proper configuration.
>
> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
> ---
> .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
This duplicates opp-table. Use OPPs instead.
Also, minimum and maximum frequencies are defined by compatible, no?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-09 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 6:18 [PATCH 0/5] Add separate ICE UFS and eMMC device nodes for QCS615 platform Abhinaba Rakshit
2025-10-09 6:18 ` [PATCH 1/5] dt-bindings: mmc: add qcom,ice phandle to mmc Abhinaba Rakshit
2025-10-09 8:20 ` Krzysztof Kozlowski
2025-10-09 6:18 ` [PATCH 2/5] dt-bindings: crypto: ice: add freq-table-hz property to ICE schema Abhinaba Rakshit
2025-10-09 8:21 ` Krzysztof Kozlowski [this message]
2025-10-09 6:18 ` [PATCH 3/5] dt-bindings: crypto: ice: document the qcs615 inline crypto engine Abhinaba Rakshit
2025-10-09 6:18 ` [PATCH 4/5] arm64: dts: qcom: qcs615: add ufs and emmc inline crypto engine nodes Abhinaba Rakshit
2025-10-09 8:24 ` Krzysztof Kozlowski
2025-10-22 17:19 ` Konrad Dybcio
2025-10-09 6:18 ` [PATCH 5/5] dts: qcom: qcs615-ride: Enable ice ufs and emmc Abhinaba Rakshit
2025-10-09 8:25 ` Krzysztof Kozlowski
2025-10-22 17:19 ` Konrad Dybcio
2025-10-09 22:03 ` [PATCH 0/5] Add separate ICE UFS and eMMC device nodes for QCS615 platform Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3087bab4-3eea-485a-a6e6-de14ebf2825c@kernel.org \
--to=krzk@kernel.org \
--cc=abhinaba.rakshit@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox